Track expression identity separately from source location - #6290
Open
runarorama wants to merge 1 commit into
Open
runarorama wants to merge 1 commit into
runarorama wants to merge 1 commit into
Conversation
[ghstack-poisoned]
This was referenced Sep 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add optional node identities to source annotations without changing their public patterns, source ranges, location equality/order, or diagnostic rendering. Combining concrete source ranges discards node identity, so an enclosing expression cannot inherit an unrelated child identity.
This supports dictionary insertion at exact expression sites in later stack entries. No parser or typechecker behavior is enabled here. Regression tests cover repeated locations, source queries, generated annotations, and location composition.
Full validation: all 13 unit suites, 22 CLI integration tests, 391 transcripts, edit/load round trips, manual rewrites, docs HTML generation, compiled fix5507 regression, and formatting passed.