Skip to content

Track expression identity separately from source location - #6290

Open
runarorama wants to merge 1 commit into
gh/runarorama/22/basefrom
gh/runarorama/22/head
Open

runarorama wants to merge 1 commit into
gh/runarorama/22/basefrom
gh/runarorama/22/head

Conversation

@runarorama

@runarorama runarorama commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Add optional node identities to source annotations without changing their public patterns, source ranges, location equality/order, or diagnostic rendering. Combining concrete source ranges discards node identity, so an enclosing expression cannot inherit an unrelated child identity.

This supports dictionary insertion at exact expression sites in later stack entries. No parser or typechecker behavior is enabled here. Regression tests cover repeated locations, source queries, generated annotations, and location composition.

Full validation: all 13 unit suites, 22 CLI integration tests, 391 transcripts, edit/load round trips, manual rewrites, docs HTML generation, compiled fix5507 regression, and formatting passed.

[ghstack-poisoned]
This was referenced Sep 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant