refactor(router): remove support for `loadChildren` string syntax by JoostK · Pull Request #43591 · angular/angular

JoostK · 2021-09-25T19:58:07Z

This commit removes the ability to configure lazy routes using a string
for loadChildren, together with the supporting classes to load an
NgModuleFactory at runtime.

BREAKING CHANGE:

It is no longer possible to use Route.loadChildren using a string
value. The following supporting classes were removed from
@angular/core:

NgModuleFactoryLoader
SystemJsNgModuleFactoryLoader

The @angular/router package no longer exports these symbols:

SpyNgModuleFactoryLoader
DeprecatedLoadChildren

The signature of the setupTestingRouter function from
@angular/core/testing has been changed to drop its NgModuleFactoryLoader
parameter, as an argument for that parameter can no longer be created.

This PR is an alternative to #43575 and removes NgModuleFactoryLoader and the string type for Route.loadChildren altogether.

google-cla · 2021-09-25T19:58:12Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-25T20:01:10Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-25T21:00:40Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-25T21:38:50Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-09-25T21:58:12Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

JoostK · 2021-09-26T14:12:59Z

These tests are retained as special handling in the VE compiler was not removed, as it's not currently worth the risk/effort to change VE's behavior.

JoostK · 2021-09-26T14:14:44Z

This is technically a breaking change (and mentioned in the commit message) to a signature that was not marked as deprecated, but I don't see a different way of achieving this. Since this is test-only code it is unlikely to be called from a library, so I'd consider this an acceptable break.

@atscott This particular change is not accounted for in the fixup commit that removes NgModuleFactoryLoader. Any g3 usages need to be cleaned up separately (or we'd have to extend the patch to undo this change and create an intermediate Injector to provide the given NgModuleFactoryLoader)

~~As long as g3 still uses loadChildren: string, we'll still need this because the tests need a way to stub the loader.~~

Ah, I see what you did. I don't think this should be an issue.

google-cla · 2021-09-27T20:05:19Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

The string syntax for `loadChildren` has been deprecated and is being removed, so this commit refactors the examples to the new syntax.

This commit removes the ability to configure lazy routes using a string for `loadChildren`, together with the supporting classes to load an `NgModuleFactory` at runtime. BREAKING CHANGE: It is no longer possible to use `Route.loadChildren` using a string value. The following supporting classes were removed from `@angular/core`: - `NgModuleFactoryLoader` - `SystemJsNgModuleFactoryLoader` The `@angular/router` package no longer exports these symbols: - `SpyNgModuleFactoryLoader` - `DeprecatedLoadChildren` The signature of the `setupTestingRouter` function from `@angular/core/testing` has been changed to drop its `NgModuleFactoryLoader` parameter, as an argument for that parameter can no longer be created.

Now that `Route.loadChildren` no longer accepts a string, there is no need for tooling to find all string-based `loadChildren` to setup lazy imports for them. As a result, the `listLazyRoutes` operation that enumerates all string-based `loadChildren` occurrences is no longer needed and is therefore removed from the compiler. The `listLazyRoutes` API remains on the `Program` interface to avoid breaking external tools that may be using this method, but those tools should ultimately move away from using this API.

alxhub

Reviewed-for: public-api

atscott

reviewed-for: public-api
reviewed-for: size-tracking

jessicajaniuk

LGTM 🍪
reviewed-for: public-api, size-tracking

alxhub · 2021-09-29T21:44:35Z

Pull Approve is confused...

…3591) This commit removes the ability to configure lazy routes using a string for `loadChildren`, together with the supporting classes to load an `NgModuleFactory` at runtime. BREAKING CHANGE: It is no longer possible to use `Route.loadChildren` using a string value. The following supporting classes were removed from `@angular/core`: - `NgModuleFactoryLoader` - `SystemJsNgModuleFactoryLoader` The `@angular/router` package no longer exports these symbols: - `SpyNgModuleFactoryLoader` - `DeprecatedLoadChildren` The signature of the `setupTestingRouter` function from `@angular/core/testing` has been changed to drop its `NgModuleFactoryLoader` parameter, as an argument for that parameter can no longer be created. PR Close #43591

Now that `Route.loadChildren` no longer accepts a string, there is no need for tooling to find all string-based `loadChildren` to setup lazy imports for them. As a result, the `listLazyRoutes` operation that enumerates all string-based `loadChildren` occurrences is no longer needed and is therefore removed from the compiler. The `listLazyRoutes` API remains on the `Program` interface to avoid breaking external tools that may be using this method, but those tools should ultimately move away from using this API. PR Close #43591

angular-automatic-lock-bot · 2021-10-30T16:06:23Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

JoostK added breaking changes area: router area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Sep 25, 2021

ngbot Bot modified the milestone: Backlog Sep 25, 2021

google-cla Bot added the cla: no label Sep 25, 2021

JoostK added the state: WIP label Sep 25, 2021

angular-robot Bot added the breaking changes label Sep 25, 2021

JoostK force-pushed the remove-loadchildren-string-all-in branch from d484e31 to 29ea269 Compare September 25, 2021 20:01

JoostK force-pushed the remove-loadchildren-string-all-in branch from 29ea269 to 7c44826 Compare September 25, 2021 21:00

JoostK force-pushed the remove-loadchildren-string-all-in branch from 7c44826 to ddbe652 Compare September 25, 2021 21:38

JoostK force-pushed the remove-loadchildren-string-all-in branch from ddbe652 to e2c84c2 Compare September 25, 2021 21:58

JoostK marked this pull request as ready for review September 25, 2021 22:30

pullapprove Bot requested review from IgorMinar and atscott September 25, 2021 22:31

JoostK added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Sep 25, 2021

JoostK commented Sep 26, 2021

View reviewed changes

dario-piotrowicz reviewed Sep 26, 2021

View reviewed changes

Comment thread aio/content/guide/deprecations.md Outdated

Comment thread packages/core/src/linker/ng_module_factory_loader.ts Outdated

atscott mentioned this pull request Sep 27, 2021

test(router): refactor tests to not use deprecated loadChildren #43578

Closed

JoostK force-pushed the remove-loadchildren-string-all-in branch from e2c84c2 to ca967e4 Compare September 27, 2021 20:05

pullapprove Bot requested review from jelbourn, jessicajaniuk, petebacondarwin and zarend September 29, 2021 19:55

JoostK added 6 commits September 29, 2021 13:53

docs: refactor example apps to use dynamic imports for loadChildren

6320c00

The string syntax for `loadChildren` has been deprecated and is being removed, so this commit refactors the examples to the new syntax.

fixup! refactor(router): remove support for loadChildren string syntax

1a9c0e4

fixup! refactor(router): remove support for loadChildren string syntax

2d16f74

fixup! refactor(router): remove support for loadChildren string syntax

eafaa78

atscott force-pushed the remove-loadchildren-string-all-in branch from 4e54706 to 04fb369 Compare September 29, 2021 20:55

alxhub added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 29, 2021

alxhub approved these changes Sep 29, 2021

View reviewed changes

atscott approved these changes Sep 29, 2021

View reviewed changes

jessicajaniuk approved these changes Sep 29, 2021

View reviewed changes

pullapprove Bot requested a review from alxhub September 29, 2021 21:41

alxhub removed request for jelbourn, petebacondarwin and zarend September 29, 2021 21:42

alxhub approved these changes Sep 29, 2021

View reviewed changes

alxhub added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 29, 2021

alxhub closed this in 05c08ca Sep 29, 2021

This was referenced Sep 30, 2021

Remove System.import() usage in favor of import() #21560

Closed

Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" error #22700

Closed

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 30, 2021

Conversation

JoostK commented Sep 25, 2021

Uh oh!

google-cla Bot commented Sep 25, 2021

Uh oh!

google-cla Bot commented Sep 25, 2021

Uh oh!

google-cla Bot commented Sep 25, 2021

Uh oh!

google-cla Bot commented Sep 25, 2021

Uh oh!

google-cla Bot commented Sep 25, 2021

Uh oh!

JoostK Sep 26, 2021

Choose a reason for hiding this comment

Uh oh!

JoostK Sep 26, 2021

Choose a reason for hiding this comment

Uh oh!

atscott Sep 29, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-cla Bot commented Sep 27, 2021

Uh oh!

alxhub left a comment

Choose a reason for hiding this comment

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alxhub commented Sep 29, 2021

Uh oh!

angular-automatic-lock-bot Bot commented Oct 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jessicajaniuk left a comment •

edited

Loading