Skip to content

refactor(router): remove support for loadChildren string syntax #43591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoostK wants to merge 6 commits into from
Closed

refactor(router): remove support for loadChildren string syntax #43591

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6320c00
docs: refactor example apps to use dynamic imports for `loadChildren`
JoostK Sep 25, 2021
fb1d1c7
refactor(router): remove support for `loadChildren` string syntax
JoostK Sep 24, 2021
1a9c0e4
fixup! refactor(router): remove support for `loadChildren` string syntax
JoostK Sep 25, 2021
2d16f74
fixup! refactor(router): remove support for `loadChildren` string syntax
JoostK Sep 25, 2021
eafaa78
fixup! refactor(router): remove support for `loadChildren` string syntax
JoostK Sep 27, 2021
04fb369
refactor(compiler-cli): remove `listLazyRoutes` operation
JoostK Sep 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! refactor(router): remove support for loadChildren string syntax
  • Loading branch information
@JoostK @atscott
JoostK authored and atscott committed Sep 29, 2021
commit 2d16f74317dee0597129ad211c123006eda2cdf1
4 changes: 2 additions & 2 deletions goldens/size-tracking/aio-payloads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
"master": {
"uncompressed": {
"runtime-es2017": 4841,
"main-es2017": 463023,
"main-es2017": 462372,
"polyfills-es2017": 55373,
"styles": 69772,
"light-theme": 79025,
"dark-theme": 78924
}
}
}
}
}
6 changes: 3 additions & 3 deletions goldens/size-tracking/integration-payloads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"master": {
"uncompressed": {
"runtime": 1105,
"main": 145314,
"main": 144744,
"polyfills": 36939
}
}
Expand All @@ -33,7 +33,7 @@
"master": {
"uncompressed": {
"runtime": 1101,
"main": 137914,
"main": 137399,
"polyfills": 37641
}
}
Expand All @@ -42,7 +42,7 @@
"master": {
"uncompressed": {
"runtime": 2843,
"main": 239937,
"main": 238453,
"polyfills": 37064,
"src_app_lazy_lazy_module_ts": 795
}
Expand Down
8 changes: 1 addition & 7 deletions packages/core/test/bundling/router/bundle.golden_symbols.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,6 @@
{
"name": "DATA_URL_PATTERN"
},
{
"name": "DEFAULT_CONFIG"
},
{
"name": "DEFAULT_CURRENCY_CODE"
},
Expand Down Expand Up @@ -995,9 +992,6 @@
{
"name": "catchError"
},
{
"name": "checkNotEmpty"
},
{
"name": "checkStable"
},
Expand Down Expand Up @@ -2105,4 +2099,4 @@
{
"name": "ɵɵtextInterpolate1"
}
]
]