Repository navigation
Conversation
JoostK
added
state: WIP
breaking changes
area: router
area: core
IgorMinar
approved these changes
Sep 24, 2021
IgorMinar
left a comment
IgorMinar
left a comment
Contributor
There was a problem hiding this comment.
LGTM for api changes. thanks!
Reviewed-for: public-api,docs-packaging-and-releasing
Contributor
There was a problem hiding this comment.
Suggested change
| return Promise.reject(new Error('string based `loadChildren` is unavailable')); | |
| return Promise.reject(new Error('`loadChildren` is no longer supported')); |
Contributor
There was a problem hiding this comment.
Suggested change
| 'The usage of `loadChildren` with a module path string is no longer available. Find more at https://v12.angular.io/api/router/LoadChildrenCallback to learn about the new approach.')); | |
| 'The usage of `loadChildren` with a module path string is no longer supported. Find more at https://v12.angular.io/api/router/LoadChildrenCallback to learn about the new approach.')); |
…ntax This commit removes the ability to configure lazy routes using a string for `loadChildren`, together with the NgModule loader implementation based on SystemJS from `@angular/core`. BREAKING CHANGE: It is no longer possible to use `Route.loadChildren` using a string value, as the runtime support for loading the corresponding NgModule has been removed from `@angular/core`.
JoostK
force-pushed
the
remove-loadchildren-string
branch
from
September 29, 2021 06:28
a8dd45f to
dfd2cb0
Compare
IgorMinar
self-requested a review
September 29, 2021 19:55
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the ability to configure lazy routes using a string
for
loadChildren, together with the NgModule loader implementationbased on SystemJS from
@angular/core.BREAKING CHANGE:
It is no longer possible to use
Route.loadChildrenusing a stringvalue, as the runtime support for loading the corresponding NgModule
has been removed from
@angular/core.