Skip to content

test(router): refactor tests to not use deprecated loadChildren - #43578

Closed
atscott wants to merge 2 commits into
angular:masterfrom
atscott:deprecatedloadchildren
Closed

test(router): refactor tests to not use deprecated loadChildren#43578
atscott wants to merge 2 commits into
angular:masterfrom
atscott:deprecatedloadchildren

Conversation

@atscott

@atscott atscott commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

Many of the tests in the router code use the deprecated loadChildren as a string. This
has been deprecated for years and can easily be changed to just a function that
returns the module.

@atscott atscott added the target: patch This PR is targeted for the next patch release label Sep 24, 2021
@google-cla google-cla Bot added the cla: yes label Sep 24, 2021
dario-piotrowicz
dario-piotrowicz reviewed Sep 24, 2021
View reviewed changes
Comment thread packages/router/test/apply_redirects.spec.ts Outdated
@atscott
atscott force-pushed the deprecatedloadchildren branch from 64c6579 to c3d0628 Compare September 24, 2021 21:47
@pullapprove
pullapprove Bot requested a review from IgorMinar September 24, 2021 21:47
@atscott
test(router): refactor tests to not use deprecated loadChildren
99e12ee 
Many of the tests in the router code use the deprecated loadChildren as a string. This
has been deprecated for years and can easily be changed to just a function that
returns the module.
@atscott
atscott force-pushed the deprecatedloadchildren branch from c3d0628 to 99e12ee Compare September 24, 2021 22:01
@ngbot ngbot Bot added this to the Backlog milestone Sep 24, 2021
@atscott

This comment has been minimized.

Sign in to view
@atscott atscott closed this Sep 27, 2021
@atscott atscott reopened this Sep 27, 2021
@JoostK JoostK self-assigned this Sep 27, 2021
@JoostK
JoostK self-requested a review September 27, 2021 17:11
JoostK
JoostK approved these changes Sep 27, 2021
View reviewed changes
Comment thread packages/router/test/integration.spec.ts Outdated
Comment thread packages/router/test/router_preloader.spec.ts Outdated
Comment thread packages/router/test/router_preloader.spec.ts Outdated
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Sep 27, 2021
@ngbot

ngbot Bot commented Sep 27, 2021

Copy link
Copy Markdown

I see that you just added the action: merge label, but the following checks are still failing:
聽聽聽聽failure status "cla/google" is failing
聽聽聽聽pending status "pullapprove" is pending
聽聽聽聽pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott
atscott removed the request for review from IgorMinar September 27, 2021 19:20
@pullapprove
pullapprove Bot requested a review from IgorMinar September 27, 2021 19:20
@atscott
atscott force-pushed the deprecatedloadchildren branch from 2b8a32b to 82c9f03 Compare September 27, 2021 19:55
@atscott atscott added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 29, 2021
@atscott

atscott commented Sep 29, 2021

Copy link
Copy Markdown
Contributor Author

merge assistance: this does now need fw-testing approval since it only modified a test under the /testing/... folder. There were no changes to the actual public testing apis

alxhub
alxhub approved these changes Sep 29, 2021
View reviewed changes

@alxhub alxhub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: global-approvers

@alxhub
alxhub removed the request for review from IgorMinar September 29, 2021 18:13
alxhub pushed a commit that referenced this pull request Sep 29, 2021
@atscott @alxhub
test(router): refactor tests to not use deprecated loadChildren (#43578)
ca0f057 
Many of the tests in the router code use the deprecated loadChildren as a string. This
has been deprecated for years and can easily be changed to just a function that
returns the module.

PR Close #43578
@alxhub alxhub closed this in 09d325a Sep 29, 2021
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Oct 30, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK approved these changes
@alxhub alxhub alxhub approved these changes
+1 more reviewer
@dario-piotrowicz dario-piotrowicz dario-piotrowicz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@JoostK JoostK

Labels

action: merge The PR is ready for merge by the caretaker area: router cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@atscott @JoostK @alxhub @dario-piotrowicz