Skip to content

Fix negative real handling and improve pole matching logic #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UbeenII wants to merge 6 commits into from
Closed

Fix negative real handling and improve pole matching logic #1216

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8821978
2 fixes. 1st fix: the m_nr branch which is meant to handle negative r…
UbeenII May 16, 2026
287ce1a
Restore original continuous test target value to fix accidental edit
UbeenII Jun 7, 2026
a1d6f4e
Update control/tests/timeresp_test.py
UbeenII Jun 9, 2026
005eebf
Update control/timeresp.py
UbeenII Jun 9, 2026
0d03091
Clean up imports in timeresp_test.py
UbeenII Jun 9, 2026
b0f9e9e
Removed blank line
UbeenII Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restore original continuous test target value to fix accidental edit
  • Loading branch information
@UbeenII
UbeenII committed Jun 7, 2026
commit 287ce1a1afb0cd0d84ff81927207cc5c426cd183
2 changes: 1 addition & 1 deletion control/tests/timeresp_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ def test_step_robustness(self):

@pytest.mark.parametrize(
"tfsys, tfinal",
[(TransferFunction(1, [1, .5]), 25), # pole at 0.5
[(TransferFunction(1, [1, .5]), 13.81551), # pole at 0.5
(TransferFunction(1, [1, .5]).sample(.1), 25), # discrete pole at 0.5
(TransferFunction(1, [1, .5, 0]), 25)]) # poles at 0.5 and 0
def test_auto_generated_time_vector_tfinal(self, tfsys, tfinal):
Expand Down
Loading