Conversation
|
The attempt to merge branch
A separate PR will be needed to merge |
bonelifer
force-pushed
the
ticket/17725
branch
from
September 24, 2026 04:15
3d7af5b to
00915fe
Compare
4 tasks done
mcp_warn.php only fires trigger_event() calls inside the branch that handles an actual warning submission. On a normal page load, a moderator opening the warn-user page, neither event fires, so there is no hook between fetching user_row and the final assign_vars() call, and the template has no event tag anywhere near the user summary block either. Adds a PHP event before the assign_vars() call exposing user_row, user_rank_data and avatar_img, plus a template event right after the rank output, matching the position of the equivalent event already proposed for mcp_warn_post.html. PHPBB-17725
bonelifer
force-pushed
the
ticket/17725
branch
from
October 1, 2026 20:43
00915fe to
307c897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17725
Adds a new PHP event
core.mcp_warn_user_modify_template_varsinmcp_warn_user_view(), right before the page'sassign_vars()call (exposinguser_row,user_rank_data,avatar_img), plus a new template eventmcp_warn_user_rank_afterright after the rank output inmcp_warn_user.html. Neither hook currently exists on a normal page load — the only existingtrigger_event()calls in this function fire solely inside the actual warning-submission branch. See the linked ticket for the full use case.