Conversation
|
The attempt to merge branch
A separate PR will be needed to merge |
bonelifer
force-pushed
the
ticket/17727
branch
from
September 24, 2026 04:15
445743f to
32c8312
Compare
4 tasks done
mcp_notes.php has zero trigger_event() calls anywhere in the file. mcp_notes_user_view() fetches userrow, computes rank_data and avatar_img, then goes straight to a single assign_vars() call with no hook point anywhere in between. The template has no event tag anywhere either, so there is no way to add anything to this page without overriding the whole template. Same gap as core.mcp_warn_user_modify_template_vars and core.mcp_warn_post_modify_template_vars - all three MCP user-detail pages share the identical details-block markup for rank/joined/posts/ warnings, and all three lacked any hook near it. Adds a PHP event before the rest of the function runs, exposing userrow, rank_data and avatar_img, plus a template event right after the rank output, at the same position as the other two. PHPBB-17727
bonelifer
force-pushed
the
ticket/17727
branch
from
October 1, 2026 20:43
32c8312 to
1d36f68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17727