Skip to content

Mkdir to always allow parents and exist ok - #2914

Merged
paulromano merged 2 commits into
openmc-dev:developfrom
shimwell:mkdir_to_always_allow_parents_and_exist_ok
Mar 17, 2024
Merged

paulromano merged 2 commits into
openmc-dev:developfrom
shimwell:mkdir_to_always_allow_parents_and_exist_ok

Conversation

@shimwell

Copy link
Copy Markdown
Member

Description

Following up on PR #2889 I think this PR allows the provided path to be a subdirectory with multiple levels of directory. I also spotted a few other places in model.py where we assume the directory is just one level deep so I updated them as well by adding parents=True to the mkdir command

Fixes # (issue)
addresses comment in PR #2889 #2889 (comment)

Checklist

  • I have performed a self-review of my own code

@paulromano paulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulromano
paulromano merged commit 231fcb6 into openmc-dev:develop Mar 17, 2024
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants