Skip to content

Mkdir to always allow parents and exist ok #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulromano merged 2 commits into from
Mar 17, 2024
Merged

Mkdir to always allow parents and exist ok #2914

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da30b9
mkdir with parents and exists ok
shimwell Mar 13, 2024
1306e33
making dir of file parent
shimwell Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions openmc/model/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ def export_to_xml(self, directory='.', remove_surfs=False):
# Create directory if required
d = Path(directory)
if not d.is_dir():
d.mkdir(parents=True)
d.mkdir(parents=True, exist_ok=True)

self.settings.export_to_xml(d)
self.geometry.export_to_xml(d, remove_surfs=remove_surfs)
Expand Down Expand Up @@ -490,14 +490,14 @@ def export_to_model_xml(self, path='model.xml', remove_surfs=False):
# exist, create it and place a 'model.xml' file there.
if not str(xml_path).endswith('.xml'):
if not xml_path.exists():
os.mkdir(xml_path)
xml_path.mkdir(parents=True, exist_ok=True)
elif not xml_path.is_dir():
raise FileExistsError(f"File exists and is not a directory: '{xml_path}'")
xml_path /= 'model.xml'
# if this is an XML file location and the file's parent directory does
# not exist, create it before continuing
elif not xml_path.parent.exists():
os.mkdir(xml_path.parent)
xml_path.parent.mkdir(parents=True, exist_ok=True)

if remove_surfs:
warnings.warn("remove_surfs kwarg will be deprecated soon, please "
Expand Down