Repository navigation
Ensure that Model.run() works when specifying a custom XML path - #2889
Merged
Merged
Conversation
Contributor
Author
|
I noticed that I was getting test failures in unrelated tests due to the use of |
pshriwise
approved these changes
Mar 12, 2024
pshriwise
left a comment
pshriwise
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the update and the CI fix @paulromano!
Member
|
ah sorry I was late to this PR. If I was earlier I would have mentioned that e.g
in other places we make use of pathlib and parents= True |
1 task done
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Model.run()method allows you to specify keyword arguments that are passed toexport_to_model_xml. If you pass apathkeyword argument, it will be used to write the corresponding XML file but it is not taken into account in the call toopenmc.runwhich will cause it to look for "model.xml" (or a set of individual XML files). This change ensures that when the user callsmodel.run(path=...), the right path is used in the call toopenmc.run().Fixes # (issue)
Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)