Repository navigation
Keep REPL history-save errors from replacing exit status - #9081
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to History-save failures no longer replace a requested SystemExit status or turn normal shell exit into a panic. No actionable merge risk remains from the reviewed change. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: history-save errors no longer replace the REPL exit status. |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
-
🧪 Generate unit tests (beta)
-
-
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Restore the two-line fix from RustPython#9078 onto main after it was merged into the Python 3.15 staging branch. Assisted-by: OpenAI Codex:model identifier unavailable
f194668 to
109ea4e
Compare
2 participants
Summary
Restore #9078 onto
main. That PR was accidentally merged intostack/python-3.15-8950; this follow-up contains only its two-linesrc/shell.rsfix in one commit based directly on current main.Treat saving REPL history as best effort on EOF and
SystemExit, preserving normal exit status when the history path cannot be written.Validation
src/shell.rsblob is identical to the reviewed Keep REPL history failures from changing exit status #9078 fix; no other files or staging-branch changes are included.git diff --checkpassed.SystemExit(7). Those runtime results belong to the earlier build, not this new main-based commit.AI assistance: OpenAI Codex prepared this restoration and checked its scope and prior evidence.
Summary by CodeRabbit