Repository navigation
Keep REPL history failures from changing exit status - #9078
youknowone merged 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [x] lib: cpython/Lib/xml dependencies:
dependent tests: (34 tests)
[x] lib: cpython/Lib/zoneinfo dependencies:
dependent tests: (2 tests)
[ ] lib: cpython/Lib/unittest dependencies:
dependent tests: (408 tests)
Legend:
|
3200984 to
a9e6f5d
Compare
Treat history persistence as best effort on EOF and SystemExit. Assisted-by: OpenAI Codex:model identifier unavailable
a9e6f5d to
786db7d
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Restore the two-line fix from RustPython#9078 onto main after it was merged into the Python 3.15 staging branch. Assisted-by: OpenAI Codex:model identifier unavailable
Restore the two-line fix from #9078 onto main after it was merged into the Python 3.15 staging branch. Assisted-by: OpenAI Codex:model identifier unavailable
Current stack and temporary CI pause
Current head:
786db7dc4e50327c3611dc9c509ab70428263650. The actual PR base isstack/python-3.15-8950; onlysrc/shell.rsdiffers from that base. Independent source review, patch equivalence, and normal hooks pass. No local build or runtime execution is claimed for this new head.The head includes
[skip ci]at the maintainer's request; required checks may remain pending. The marker changes no code and does not itself cancel older runs or suppresspull_request_targetworkflows.Summary
Treat REPL history persistence as best effort on EOF and SystemExit. The two existing save calls no longer panic when the owned history destination cannot be written, so the intended exit status is preserved.
This narrowed branch has no changes under
Lib/. The earlier ElementPath, pure-Python zoneinfo and unittest-loader changes are deferred to the Python 3.15 library refresh. Their paired changes are removed together; existing main tests remain unchanged.Prerequisite and source
This PR targets upstream
stack/python-3.15-8950at #8950's frozen80d3e52f32341d3158c659d82a927373b51b6439. It inherits Python 3.15.0 and retains only the two-line REPL fix. The obsolete Python 3.14.8 pin, TextIOWrapper change, and unrelated ParamSpec prerequisite are removed.The behavior follows the best-effort CPython history writer.
Historical validation
Fresh local validation at
a9e6f5d115f2b395741cb086cab91f3b94cf9275passed:Earlier rebase validation used a shared-target binary carrying stale compiler/VM artifacts; it is not evidence of exact-head coverage. The clean rebuild and verified artifact above replace that local claim.
No full workspace, all-snippet or broad compiler suite was run for this narrowed head. Non-Linux REPL runtime behavior was not tested locally. These runtime results belong to the earlier head; current-head hosted CI is temporarily skipped.
AI-assisted implementation, source review, rebase and validation with OpenAI Codex; assistance is disclosed in the retained commit trailers.