Skip to content

Keep REPL history failures from changing exit status - #9078

Merged
youknowone merged 1 commit into
RustPython:stack/python-3.15-8950from
youknowdot:fix-python314-library-compatibility-batch
Oct 11, 2026
Merged

youknowone merged 1 commit into
RustPython:stack/python-3.15-8950from
youknowdot:fix-python314-library-compatibility-batch

Conversation

@youknowdot

@youknowdot youknowdot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Current stack and temporary CI pause

Current head: 786db7dc4e50327c3611dc9c509ab70428263650. The actual PR base is stack/python-3.15-8950; only src/shell.rs differs from that base. Independent source review, patch equivalence, and normal hooks pass. No local build or runtime execution is claimed for this new head.

The head includes [skip ci] at the maintainer's request; required checks may remain pending. The marker changes no code and does not itself cancel older runs or suppress pull_request_target workflows.

Summary

Treat REPL history persistence as best effort on EOF and SystemExit. The two existing save calls no longer panic when the owned history destination cannot be written, so the intended exit status is preserved.

This narrowed branch has no changes under Lib/. The earlier ElementPath, pure-Python zoneinfo and unittest-loader changes are deferred to the Python 3.15 library refresh. Their paired changes are removed together; existing main tests remain unchanged.

Prerequisite and source

This PR targets upstream stack/python-3.15-8950 at #8950's frozen 80d3e52f32341d3158c659d82a927373b51b6439. It inherits Python 3.15.0 and retains only the two-line REPL fix. The obsolete Python 3.14.8 pin, TextIOWrapper change, and unrelated ParamSpec prerequisite are removed.

The behavior follows the best-effort CPython history writer.

Historical validation

Fresh local validation at a9e6f5d115f2b395741cb086cab91f3b94cf9275 passed:

  • Removed all local workspace-package artifacts before rebuilding codegen/VM and the interpreter. Recorded the binary hash and verified its commit identity and unchanged-main compiler behavior.
  • Eight isolated Linux REPL cases: CPython 3.14.8/native × writable/ENOTDIR history × EOF/SystemExit(7). Each child uses fresh owned HOME/configuration/history paths, strict timeouts and a writable-history control. All preserve exit 0/7.
  • Focused prerequisite typing and TextIOWrapper checks, main's nested template-format annotation cases, and four exact CPython/native pytest entries.
  • Warnings-denied codegen, VM, root binary and CAPI Clippy, normal hooks and independent retained-patch review.

Earlier rebase validation used a shared-target binary carrying stale compiler/VM artifacts; it is not evidence of exact-head coverage. The clean rebuild and verified artifact above replace that local claim.

No full workspace, all-snippet or broad compiler suite was run for this narrowed head. Non-Linux REPL runtime behavior was not tested locally. These runtime results belong to the earlier head; current-head hosted CI is temporarily skipped.

AI-assisted implementation, source review, rebase and validation with OpenAI Codex; assistance is disclosed in the retained commit trailers.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 645f5055-ebf3-4449-bc17-bd47baa82574

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/xml
[ ] test: cpython/Lib/test/test_xml_etree.py (TODO: 28)
[ ] test: cpython/Lib/test/test_xml_etree_c.py
[x] test: cpython/Lib/test/test_minidom.py (TODO: 4)
[x] test: cpython/Lib/test/test_pulldom.py (TODO: 3)
[ ] test: cpython/Lib/test/test_pyexpat.py (TODO: 49)
[x] test: cpython/Lib/test/test_sax.py (TODO: 28)
[x] test: cpython/Lib/test/test_xml_dom_minicompat.py
[x] test: cpython/Lib/test/test_xml_dom_xmlbuilder.py

dependencies:

  • xml

dependent tests: (34 tests)

  • xml: test_doctest test_minidom test_pulldom test_pydoc test_pyexpat test_regrtest test_sax test_typing test_xml_dom_minicompat test_xml_dom_xmlbuilder test_xml_etree
    • plistlib: test_plistlib
      • platform: test__locale test__osx_support test_asyncio test_baseexception test_builtin test_cmath test_ctypes test_fcntl test_math test_mimetypes test_os test_platform test_posix test_shutil test_socket test_ssl test_strptime test_sysconfig test_time test_winreg test_wsgiref
    • xmlrpc.client: test_xmlrpc

[x] lib: cpython/Lib/zoneinfo
[ ] test: cpython/Lib/test/test_zoneinfo

dependencies:

  • zoneinfo

dependent tests: (2 tests)

  • zoneinfo: test_plistlib test_zoneinfo

[ ] lib: cpython/Lib/unittest
[ ] test: cpython/Lib/test/test_unittest (TODO: 1)

dependencies:

  • unittest (native: _io, _log, async_case, builtins, case, loader, main, os.path, result, runner, signals, suite, sys, time, unittest.util, util)
    • asyncio (native: _asyncio, _overlapped, _pyrepl.console, _pyrepl.main, _pyrepl.simple_interact, _remote_debugging, _winapi, asyncio.tools, base_events, collections.abc, concurrent.futures, coroutines, errno, events, exceptions, futures, graph, itertools, locks, log, math, msvcrt, protocols, queues, readline, runners, streams, sys, taskgroups, tasks, threads, time, timeouts, transports, unix_events, windows_events)
    • io (native: _io, _thread, errno, msvcrt, sys)
    • logging (native: atexit, collections.abc, email.message, email.utils, errno, http.client, logging.handlers, multiprocessing.queues, select, sys, time, urllib.parse, win32evtlog, win32evtlogutil)
    • warnings (native: _contextvars, _thread, _warnings, builtins, sys)
    • _colorize, annotationlib, argparse, collections, contextlib, contextvars, dataclasses, difflib, fnmatch, functools, inspect, os, pkgutil, pprint, re, signal, threading, traceback, types, weakref

dependent tests: (408 tests)

  • unittest: regrtestdata test___all__ test__colorize test__locale test__opcode test__osx_support test_abc test_abstract_numbers test_android test_annotationlib test_apple test_argparse test_array test_asdl_parser test_ast test_asyncgen test_asyncio test_atexit test_audit test_augassign test_base64 test_baseexception test_bdb test_bigaddrspace test_bigmem test_binascii test_binop test_bisect test_bool test_buffer test_bufio test_builtin test_bytes test_bz2 test_c_locale_coercion test_calendar test_call test_charmapcodec test_class test_clinic test_cmath test_cmd test_cmd_line test_cmd_line_script test_code test_code_module test_codeccallbacks test_codecencodings_cn test_codecencodings_hk test_codecencodings_iso2022 test_codecencodings_jp test_codecencodings_kr test_codecencodings_tw test_codecmaps_cn test_codecmaps_hk test_codecmaps_jp test_codecmaps_kr test_codecmaps_tw test_codecs test_codeop test_collections test_colorsys test_compare test_compile test_compileall test_complex test_concurrent_futures test_configparser test_contains test_context test_contextlib test_contextlib_async test_copy test_copyreg test_coroutines test_cprofile test_csv test_ctypes test_datetime test_dbm test_dbm_dumb test_dbm_sqlite3 test_decimal test_decorators test_defaultdict test_deque test_descr test_descrtut test_devpoll test_dict test_dictcomps test_dictviews test_difflib test_dis test_doctest test_doctest2 test_docxmlrpc test_dtrace test_dummy_thread test_dummy_threading test_dynamic test_dynamicclassattribute test_eintr test_email test_embed test_ensurepip test_enum test_enumerate test_eof test_epoll test_errno test_except_star test_exception_group test_exception_hierarchy test_exception_variations test_exceptions test_extcall test_external_inspection test_faulthandler test_fcntl test_file test_file_eintr test_filecmp test_fileinput test_fileio test_fileutils test_finalization test_float test_flufl test_fnmatch test_fork1 test_format test_fractions test_frame test_frozen test_fstring test_ftplib test_funcattrs test_functools test_future_stmt test_gc test_generated_cases test_generator_stop test_generators test_genericalias test_genericclass test_genericpath test_genexps test_getopt test_getpass test_gettext test_glob test_global test_grammar test_graphlib test_grp test_gzip test_hash test_hashlib test_heapq test_hmac test_html test_htmlparser test_http_cookiejar test_http_cookies test_httplib test_httpservers test_idle test_imaplib test_importlib test_index test_inspect test_int test_int_literal test_io test_ioctl test_ipaddress test_isinstance test_iter test_iterlen test_itertools test_json test_keyword test_keywordonlyarg test_kqueue test_largefile test_launcher test_linecache test_list test_listcomps test_locale test_logging test_long test_longexp test_lzma test_mailbox test_marshal test_math test_math_property test_memoryio test_memoryview test_metaclass test_mimetypes test_minidom test_mmap test_modulefinder test_monitoring test_msvcrt test_multibytecodec test_multiprocessing_fork test_multiprocessing_forkserver test_multiprocessing_main_handling test_multiprocessing_spawn test_named_expressions test_netrc test_ntpath test_nturl2path test_numeric_tower test_opcache test_opcodes test_openpty test_operator test_optimizer test_optparse test_ordered_dict test_os test_osx_env test_pathlib test_patma test_pdb test_peepholer test_peg_generator test_pep646_syntax test_perfmaps test_pickle test_picklebuffer test_pickletools test_pkg test_pkgutil test_platform test_plistlib test_poll test_popen test_poplib test_positional_only_arg test_posix test_posixpath test_pow test_pprint test_print test_profile test_property test_pstats test_pty test_pulldom test_pwd test_py_compile test_pyclbr test_pydoc test_pyexpat test_pyrepl test_queue test_quopri test_raise test_random test_range test_re test_regrtest test_repl test_reprlib test_resource test_richcmp test_rlcompleter test_robotparser test_runpy test_sax test_sched test_scope test_script_helper test_secrets test_select test_selectors test_set test_setcomps test_shelve test_shlex test_shutil test_signal test_site test_slice test_smtplib test_smtpnet test_socket test_socketserver test_sort test_sqlite3 test_ssl test_stable_abi_ctypes test_stat test_statistics test_str test_strftime test_string test_string_literals test_stringprep test_strptime test_strtod test_struct test_structseq test_subclassinit test_subprocess test_sundry test_super test_support test_symtable test_syntax test_sys test_sys_setprofile test_sys_settrace test_sysconfig test_syslog test_tabnanny test_tarfile test_tempfile test_termios test_textwrap test_thread test_thread_local_bytecode test_threadedtempfile test_threading test_threading_local test_threadsignals test_time test_timeit test_timeout test_tokenize test_tomllib test_tools test_trace test_traceback test_tracemalloc test_tstring test_tty test_tuple test_turtle test_type_aliases test_type_annotations test_type_cache test_type_comments test_type_params test_typechecks test_types test_typing test_ucn test_unary test_unicode_file test_unicode_file_functions test_unicode_identifiers test_unicodedata test_unittest test_univnewlines test_unpack test_unpack_ex test_unparse test_urllib test_urllib2 test_urllib2_localnet test_urllib2net test_urllib_response test_urllibnet test_urlparse test_userdict test_userlist test_userstring test_utf8_mode test_utf8source test_uuid test_venv test_wait3 test_wait4 test_wave test_weakref test_weakset test_webbrowser test_winapi test_winconsoleio test_winreg test_winsound test_with test_wmi test_wsgiref test_xml_dom_minicompat test_xml_dom_xmlbuilder test_xml_etree test_xml_etree_c test_xmlrpc test_xpickle test_xxlimited test_xxtestfuzz test_yield_from test_zipapp test_zipfile test_zipfile64 test_zipimport test_zipimport_support test_zlib test_zoneinfo test_zstd

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@youknowdot
youknowdot force-pushed the fix-python314-library-compatibility-batch branch 2 times, most recently from 3200984 to a9e6f5d Compare October 11, 2026 01:01
@youknowdot youknowdot changed the title Fix Python 3.14 library parsing, test loading, and REPL exits Keep REPL history failures from changing exit status Oct 11, 2026
Treat history persistence as best effort on EOF and SystemExit.

Assisted-by: OpenAI Codex:model identifier unavailable
@youknowone
youknowone changed the base branch from main to stack/python-3.15-8950 October 11, 2026 03:28
@youknowdot
youknowdot force-pushed the fix-python314-library-compatibility-batch branch from a9e6f5d to 786db7d Compare October 11, 2026 03:28
@youknowone
youknowone marked this pull request as ready for review October 11, 2026 03:28
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@youknowone
youknowone merged commit 71dcb80 into RustPython:stack/python-3.15-8950 Oct 11, 2026
1 check passed
youknowdot added a commit to youknowdot/RustPython that referenced this pull request Oct 11, 2026
Restore the two-line fix from RustPython#9078 onto main after it was merged into the Python 3.15 staging branch.

Assisted-by: OpenAI Codex:model identifier unavailable
youknowone pushed a commit that referenced this pull request Oct 11, 2026
Restore the two-line fix from #9078 onto main after it was merged into the Python 3.15 staging branch.

Assisted-by: OpenAI Codex:model identifier unavailable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants