Repository navigation
Sync email, mock, logging, and console behavior with Python 3.15 - #9079
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (12)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [ ] lib: cpython/Lib/unittest dependencies:
dependent tests: (408 tests)
[ ] lib: cpython/Lib/site.py dependencies:
dependent tests: (1 tests)
[x] lib: cpython/Lib/tabnanny.py dependencies:
dependent tests: (1 tests)
[ ] lib: cpython/Lib/email dependencies:
dependent tests: (54 tests)
[x] lib: cpython/Lib/logging dependencies:
dependent tests: (90 tests)
[ ] lib: cpython/Lib/encodings dependencies:
dependent tests: (160 tests)
Legend:
|
1dc15a4 to
3d97ea8
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
Import exact d220409a13b77de7a6c30abe16ea90db01528edc sources through scripts/update_lib migrate, preserving the existing logging test marker. Retain focused Python license and mock property regressions outside Lib. This later Python-stage change requires native binascii wrapcol support; listener DNS runtime validation remains out of scope. Assisted-by: OpenAI Codex:model identifier unavailable
3d97ea8 to
e220bc4
Compare
There was a problem hiding this comment.
do NOT add extra_tests for Lib udpate. lib update must be run by update_lib script
Remove the two PR-added extra_tests snippets as requested in review. Preserve the script-migrated CPython library files and their canonical tests unchanged. Assisted-by: OpenAI Codex:model identifier unavailable
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f62270b00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| """Should display usage on no arguments.""" | ||
| path = findfile('tabnanny.py') | ||
| stderr = f"Usage: {path} [-v] file_or_directory ..." | ||
| stderr = f"Usage: {sys.executable} -m tabnanny [-v] file_or_directory ..." |
There was a problem hiding this comment.
Revert the test expectation change
This rewrites the expected stderr of an existing test, but the repository’s test-modification policy explicitly prohibits changing test assertions, logic, or data and permits only adding or removing expectedFailure markers. Keep the existing test expectation rather than updating test data as part of this library sync.
AGENTS.md reference: AGENTS.md:L273-L279
Useful? React with 👍 / 👎.
Summary
Sync email content management, encodings aliases, unittest.mock, logging, tabnanny and the license pager with the pinned official CPython 3.15.0 source d220409a13b77de7a6c30abe16ea90db01528edc.
scripts/update_lib migratecommand.Eleven changed Lib files are byte-identical to the pinned source. test_logging differs only by its pre-existing RustPython expectedFailure marker. No manual Lib edits or compatibility backports are included.
Validation
The native executable was built by the official main release workflow, not rebuilt at this PR head. Full workspace/C-API/Clippy suites, broad logging/listener/DNS behavior, interactive/external pagers and Windows behavior were not run locally. Hosted CI must be checked for the exact final head.
AI assistance
OpenAI Codex performed the scripted migration, source review and focused validation. The model identifier is unavailable in this environment. This does not claim completed human validation or readiness to merge.