Repository navigation
Add row and col facade for 2 dim container - #1876
Merged
Merged
Conversation
Member
|
Thanks for this PR! See my comments in the review. |
JohanMabille
requested changes
Jan 1, 2020
JohanMabille
approved these changes
Jan 2, 2020
Member
|
Awesome, thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is related to #1189.
Row and col shortcuts for two-dimensional containers make the code more readable.
The implementation is straight forward. The row and col function can only be called on a two-dimensional container. If the functions are called on a container with other dimension an error occurs.
If the container has compile-constant dimensions, a static_assert will fail the build.
If the container has runtime-specific dimensions, a std::invalid_argument exception is thrown.
Please check if your PR fulfills these requirements
in both docs/source/changelog.rst and include/xtensor/xtensor_config.hpp according
to the following rules: