Repository navigation
Update Cmake to allow third-party libraries - #2006
Conversation
paulromano
left a comment
There was a problem hiding this comment.
Thanks @kkiesling and congrats on your first PR here! 🎉 Just a few comments regarding how we handle xtl
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
|
I think I have at least one solution to one of the build errors coming from For the other build error with |
…onsistent with vendored versions
|
One last change and hopefully this makes it work- I updated the xtl and xtensor versions on the CI build script for vectfit to be the versions that are vendored. This new find_package change was finding the versions installed with vectfit, but they were too old and didn't have some of the functions currently used by openmc. |
paulromano
left a comment
There was a problem hiding this comment.
Looks good! Thanks for working through the strange build issues 😄 Will merge tomorrow morning if there's no more feedback
Update Cmake to allow third-party libraries
This addresses #1779. CMake will now search for existing installations of xtensor, xtl, and gsl-lite and use those instead. If not found, it'll use the vendored submodules.