Skip to content

WIP: Upgrade to 7.4 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loganhenson merged 19 commits into from
Dec 6, 2019
Merged

WIP: Upgrade to 7.4 #67

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d13c86e
Upgrade to 7.4 poc.
loganhenson Oct 23, 2019
1929183
Update php.yml
loganhenson Oct 23, 2019
e87b88c
Update php.yml
loganhenson Oct 23, 2019
a4e36b6
Update readme
loganhenson Oct 23, 2019
f61632b
remove travis
loganhenson Oct 23, 2019
998820e
Update composer deps.
loganhenson Oct 24, 2019
b0b8bd1
Update to official 7.4 image & Remove nightly tests.
loganhenson Oct 24, 2019
425d034
Merge branch 'master' of github.com:vector-php/vector into lh-php-7.4
loganhenson Oct 24, 2019
5849176
checkpoint
loganhenson Oct 24, 2019
3714afe
checkpoint
loganhenson Oct 24, 2019
e1d7515
Housekeeping.
loganhenson Oct 25, 2019
e726e24
Add auto-unwrapping to pattern matching.
loganhenson Oct 25, 2019
15dd036
Finish Housekeeping.
loganhenson Oct 25, 2019
8c4d37c
Backtrack auto-unwrapping, unless it ignores arguments (scalar return…
loganhenson Oct 25, 2019
302a568
Update it_can_match_on_extractable to use Strings::concat.
loganhenson Oct 25, 2019
69b680e
Remove old imports.
loganhenson Oct 25, 2019
466154c
Fix contact -> concat docblock.
loganhenson Oct 26, 2019
8441900
Add test that ensures optional param matching behavior.
loganhenson Oct 26, 2019
b6dfd95
use official docker image php 7.4
loganhenson Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Backtrack auto-unwrapping, unless it ignores arguments (scalar return… 
… value).
  • Loading branch information
@loganhenson
loganhenson committed Oct 25, 2019
commit 8c4d37cb31d3f1f4c7ea9c8241b06abee9c1ad67
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ $addSix(4); // 10;
Pattern Matching.
```php
Pattern::match([
fn(Just $value) => $unwrapped,
fn(Just $value) => fn ($unwrapped) => $unwrapped,
fn(Nothing $value) => 'nothing',
])(Maybe::just('just')); // 'just'
```
Expand All @@ -60,7 +60,7 @@ $errorHandler = function (Err $err) {
};

return Pattern::match([
fn(Ok $value) => $user,
fn(Ok $value) => fn (User $user) => $user,
$errorHandler
])(Result::from(fn() => User::findOrFail(1)));
```
8 changes: 4 additions & 4 deletions tests/Control/PatternTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ public function it_matches_on_type()
public function it_can_match_on_result_ok()
{
$match = Pattern::match([
fn (Ok $value) => fn (int $value) => $value + 2,
fn (Ok $value) => fn (string $value) => $value . 'bc',
fn (Err $error) => 'nothing',
]);

$this->assertEquals(3, $match(Result::ok(1)));
$this->assertEquals('abc', $match(Result::ok('a')));
}

/** @test */
Expand All @@ -71,11 +71,11 @@ public function it_can_match_on_result_err()
public function it_can_match_on_maybe_just()
{
$match = Pattern::match([
fn (Just $value) => $value + 2,
fn (Just $value) => fn (string $value) => $value . 'bc',
fn (Nothing $_) => 'nothing',
]);

$this->assertEquals(3, $match(Maybe::just(1)));
$this->assertEquals('abc', $match(Maybe::just('a')));
}

/** @test */
Expand Down