WIP: Upgrade to 7.4 - #67
Merged
Merged
Conversation
loganhenson
force-pushed
the
lh-php-7.4
branch
from
October 24, 2019 17:52
ceee01d to
173c3ca
Compare
loganhenson
force-pushed
the
lh-php-7.4
branch
from
October 24, 2019 18:17
8a8443c to
b0b8bd1
Compare
| Class MyFunctions extends Module { | ||
| protected $memoize = ['myFunction']; | ||
|
|
||
| protected static myFunction() { |
Collaborator
There was a problem hiding this comment.
Does the Module memoize prepend the magic double-underscore? I think it does, so this would be __myFunction(). Double check prob.
| - `Arrays::map(fn($a) => $a + 1)([1, 2, 3])` (_Vector_) | ||
|
|
||
| - You can add currying to any function, it isn't only limited to Vector built ins. | ||
| - `Module::curry('implode')(',')('a,b,c')` `// ['a', 'b', 'c']` |
Collaborator
There was a problem hiding this comment.
It never occurred to me you could do this lol
| }; | ||
| }, | ||
| fn(Just $value) => fn(string $unwrapped) => $unwrapped, | ||
| fn(Nothing $value) => fn() => 'nothing', |
Collaborator
There was a problem hiding this comment.
Would it be possible to change the syntax without the extra layer of lambda / fat arrow? Like:
fn(Just $value) => $value,
fn(Nothing $_) => 'nothing',
Collaborator
Author
There was a problem hiding this comment.
so like auto extract?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.