Skip to content

test: xfail v1 UNI-exchange price-output cases (no liquidity) #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimeToBuildBob wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

test: xfail v1 UNI-exchange price-output cases (no liquidity) #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: xfail v1 UNI-exchange price-output cases (no liquidity — Invali… 
…dJump)

The three ETH-UNI / UNI-ETH test_get_price_output parametrizations fail on the
v1 mainnet job because the v1 UNI exchange contract has no remaining liquidity
and the Vyper bytecode hits EVM error InvalidJump. This is pre-existing
(depot unchanged since the branch's first push) and blocks every PR's CI.

Runtime-xfail only fires for version==1 UNI pairs; v2/v3 UNI cases keep passing.

Git-Session-Id: 3d27
  • Loading branch information
@TimeToBuildBob
TimeToBuildBob committed Sep 1, 2026
commit 9fcbe22a55db41ceb6763c7a159e4873ad5b73bc
2 changes: 2 additions & 0 deletions tests/test_uniswap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@ def test_get_price_input(self, client: Uniswap, tokens, token0, token1, qty):
],
)
def test_get_price_output(self, client: Uniswap, tokens, token0, token1, qty):
if client.version == 1 and "UNI" in (token0, token1):
pytest.xfail("Uniswap v1 UNI exchange has no liquidity — InvalidJump")
token0, token1 = tokens[token0], tokens[token1]
if client.version == 1 and ETH_ADDRESS not in [token0, token1]:
pytest.skip("Not supported in this version of Uniswap")
Expand Down
Loading