test: xfail v1 UNI-exchange price-output cases (no liquidity) - #479
TimeToBuildBob wants to merge 1 commit into
Conversation
…dJump) The three ETH-UNI / UNI-ETH test_get_price_output parametrizations fail on the v1 mainnet job because the v1 UNI exchange contract has no remaining liquidity and the Vyper bytecode hits EVM error InvalidJump. This is pre-existing (depot unchanged since the branch's first push) and blocks every PR's CI. Runtime-xfail only fires for version==1 UNI pairs; v2/v3 UNI cases keep passing. Git-Session-Id: 3d27
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 12 12
Lines 2319 2319
=======================================
Hits 1699 1699
Misses 620 620 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Greptile SummaryThis PR marks the three V1 UNI exact-output quote cases as expected failures because the liquidity-free legacy exchange reverts on the mainnet fork.
Confidence Score: 5/5The PR appears safe to merge because the new condition covers exactly the documented failing V1 UNI output-price cases. The xfail is restricted by both protocol version and token symbol, while every intercepted parameterization reaches the legacy UNI exchange and previously fails rather than taking the existing unsupported-pair skip. Important Files Changed
Reviews (1): Last reviewed commit: "test: xfail v1 UNI-exchange price-output..." | Re-trigger Greptile |
|
Friendly ping for review when you get a chance — all 7 checks are green on this one (including the previously-failing v1 mainnet job). Once it merges, PR #478's last red check should resolve on re-run. |
Same fix as uniswap-python#479 — the v1 UNI exchange has no remaining liquidity so get_price_output raises EVM error InvalidJump on mainnet fork. Git-Session-Id: 8f77
This branch has not been deployed
1 participant
Problem
The
test (v1, mainnet)job fails on every PR with 3 identical failures: the ETH-UNI / UNI-ETHtest_get_price_outputparametrizations hit the Uniswap v1 UNI exchange contract, which has no remaining liquidity — the Vyper bytecode raisesEVM error InvalidJump. This is pre-existing (same failures on the first push of #478) and unrelated to any current change.Fix
Runtime
pytest.xfail()intest_get_price_outputwhenversion == 1and the pair involves UNI. v2/v3 UNI cases keep passing, and any other v1 pair is unaffected. 2 lines.Verification
InvalidJump; all 4 other jobs + build + typecheck green)Ref: #478