Skip to content

[cxx-interop] Add a MutableCollection test that relies on std::string being Comparable - #76313

Merged
egorzhdan merged 1 commit into
mainfrom
egorzhdan/std-vector-string-comparable
Sep 6, 2024
Merged

[cxx-interop] Add a MutableCollection test that relies on std::string being Comparable#76313
egorzhdan merged 1 commit into
mainfrom
egorzhdan/std-vector-string-comparable

Conversation

@egorzhdan

@egorzhdan egorzhdan commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

This is possible after #76223.

@egorzhdan
[cxx-interop] Add a MutableCollection test that relies on `std::str…
dd78e3b 
…ing` being `Comparable`

This is possible after #76223.
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Sep 6, 2024
@egorzhdan
egorzhdan requested a review from Xazax-hun September 6, 2024 16:03
@egorzhdan

egorzhdan commented Sep 6, 2024

Copy link
Copy Markdown
Contributor Author

@swift-ci please smoke test

Xazax-hun
Xazax-hun approved these changes Sep 6, 2024
View reviewed changes

@Xazax-hun Xazax-hun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@egorzhdan
egorzhdan enabled auto-merge September 6, 2024 16:37
@egorzhdan
egorzhdan merged commit a0fb54c into main Sep 6, 2024
@egorzhdan
egorzhdan deleted the egorzhdan/std-vector-string-comparable branch September 6, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xazax-hun Xazax-hun Xazax-hun approved these changes
@zoecarver zoecarver Awaiting requested review from zoecarver
@hyp hyp Awaiting requested review from hyp

Assignees

No one assigned

Labels

c++ interop Feature: Interoperability with C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@egorzhdan @Xazax-hun