Repository navigation
Add comparable conformance for C++ strings - #76223
Merged
egorzhdan merged 1 commit intoSep 4, 2024
Merged
Conversation
Contributor
Author
Sure, working on it! |
ishon19
changed the title
egorzhdan
reviewed
Sep 3, 2024
egorzhdan
left a comment
egorzhdan
left a comment
Contributor
There was a problem hiding this comment.
This is looking great! I only have one comment on the implementation.
On a separate note, could you please also squash the two commits into a single commit?
ishon19
force-pushed
the
76220-string-should-conform-to-comparable
branch
from
September 3, 2024 17:51
83d69e2 to
49d9067
Compare
Contributor
Author
Thanks @egorzhdan! Sure, merged them all in a single commit now. |
Contributor
|
@swift-ci please test |
Contributor
Author
Thanks for the review @egorzhdan! :) |
egorzhdan
added a commit
that referenced
this pull request
Sep 6, 2024
…ing` being `Comparable` This is possible after #76223.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
Comparableconformance for C++ strings.Fixes #76220