Skip to content

[Suggestion] Restructure package folder? #162

Description

@XzzX

This is about this folder https://github.com/pythonworkflow/python-workflow-definition/tree/main/src/python_workflow_definition

Activity

  1. jan-janssen commented on Jan 20, 2026

    @jan-janssen
    Member

    Hi @XzzX ,

    • I agree that the workflow engine specific part should ideally be included in the workflow engines. At the moment it is primarily included in this repository to enable faster iteration of the Python Workflow Definition.
    • Simply for historic reasons - pydantic classes were only added later on Add pydantic validation #97
    • I agree it makes sense to separate the JSON writer to a separate module.

    While I am not exactly sure how we want to address the first issue, the second and third could be address directly. Feel free to open a corresponding pull request.

  2. changed the title [-]Restructure package folder?[/-] [+][Suggestion] Restructure package folder?[/+] on Jan 20, 2026
  3. XzzX commented on Jan 21, 2026

    @XzzX
    Author

    These are API breaking changes. Is that ok?

  4. jan-janssen commented on Jan 21, 2026

    @jan-janssen
    Member

    These are API breaking changes. Is that ok?

    I guess we have to properly increase the version but as long as the JOSN format remains the same, I am fine. I think the main focus at the moment is on maintaining backwards compatibility to exported workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions