Repository navigation
[Suggestion] Restructure package folder? #162
Description
This is about this folder https://github.com/pythonworkflow/python-workflow-definition/tree/main/src/python_workflow_definition
- Move WfM specific stuff into own repositories? For me they do not belong into a spec repository.
- Why is https://github.com/pythonworkflow/python-workflow-definition/blob/main/src/python_workflow_definition/shared.py not using the pydantic models?
- What is this for? https://github.com/pythonworkflow/python-workflow-definition/blob/main/src/python_workflow_definition/models.py#L123-L254 In my opinion this does not belong to the spec and irritates as the names are pretty similar to functions provided by pydantic.
Activity
jan-janssen commentedon Jan 20, 2026
Hi @XzzX ,
While I am not exactly sure how we want to address the first issue, the second and third could be address directly. Feel free to open a corresponding pull request.
[-]Restructure package folder?[/-][+][Suggestion] Restructure package folder?[/+]XzzX commentedon Jan 21, 2026
These are API breaking changes. Is that ok?
jan-janssen commentedon Jan 21, 2026
I guess we have to properly increase the version but as long as the JOSN format remains the same, I am fine. I think the main focus at the moment is on maintaining backwards compatibility to exported workflows.