Skip to content

Fix bug in matched transformation + address other issues in #950 #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murrayrm merged 3 commits into from
Dec 26, 2023
Merged

Fix bug in matched transformation + address other issues in #950 #951

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fb1a51
fix bug in matched transformation + address other issues in #950
murrayrm Dec 26, 2023
d4525a1
Update control/xferfcn.py
murrayrm Dec 26, 2023
e4bcec0
fixed botched pathc from github
murrayrm Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixed botched pathc from github
  • Loading branch information
@murrayrm
murrayrm committed Dec 26, 2023
commit e4bcec01cda450ab12a44b456c8351d8af1d83ce
3 changes: 1 addition & 2 deletions control/xferfcn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,8 +1288,7 @@ def _isstatic(self):
# c2d function contributed by Benjamin White, Oct 2012
def _c2d_matched(sysC, Ts, **kwargs):
if not sysC.issiso():
raise ControlMIMONotImplemented("Not implemented for MIMO systems")
raise ValueError("MIMO transfer functions not supported")
raise ControlMIMONotImplemented("Not implemented for MIMO systems")

# Pole-zero match method of continuous to discrete time conversion
szeros, spoles, _ = tf2zpk(sysC.num[0][0], sysC.den[0][0])
Expand Down