Repository navigation
a first implementation of the singular value plot as discussed in #592 #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bnavigator
merged 37 commits into
python-control:master
from
forgi86:singular-values-plot
Apr 29, 2021
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
43e3779
DEV:
forgi86 ae7d546
Update control/freqplot.py
forgi86 36e8b77
Update control/freqplot.py
forgi86 4e055bb
FIX:
forgi86 14ef194
Merge remote-tracking branch 'origin/singular-values-plot' into singu…
forgi86 681edb7
FIX:
forgi86 8d02fae
FIX:
forgi86 fe97069
FIX:
forgi86 762fbd6
FIX: development of parametrized tests for the singular_values_plot f…
forgi86 3b09ae7
FIX: using option squeeze=False to keep all dimensions from the frequ…
forgi86 9c68700
FIX:
forgi86 a392c97
DOC:
forgi86 caa3e2c
FIX:
forgi86 0607314
FIX:
forgi86 65b4e49
TST:
forgi86 87d48ab
TST:
forgi86 a289f8c
MAINT: refactoring of the frequency selection logic as a private func…
forgi86 fbafc6c
FIX: added missing omega vector in test system ss_siso_ct
forgi86 7f5d66c
TST:
forgi86 81f9ee7
TST: added a test condition that expects the warning to be issued whe…
forgi86 7d19b30
MAINT:
forgi86 34c3826
DOC: updated example for singular_values_plot
forgi86 48015d5
MAINT: _bode_defaults removed, fields moved in _freqplot_default
forgi86 38dfeda
MAINT: no warning issued for evaluation above the Nyquist frequency
forgi86 555902b
MAINT: removing references to singular_values_plot configurations
forgi86 ec69337
MAINT: removing references to singular_values_plot configurations
forgi86 288a7ee
MAINT: removing references to bode configurations (use freqplot instead)
forgi86 8f3f76d
Update control/freqplot.py
forgi86 fb3d9a0
MAINT: the Hz parameter of bode_plot and singular_values_plot now onl…
forgi86 37c0962
DOC: bode changed to freqplot in conventions.rst
forgi86 a486c18
Merge remote-tracking branch 'origin/singular-values-plot' into singu…
forgi86 9143d75
Merge branch 'master' into singular-values-plot
forgi86 f5de343
DOC: modified docstring (Examples section) in singular_values_plot to…
forgi86 9638e92
DOC: modified docstring (Examples section) in singular_values_plot to…
forgi86 10cde40
DOC: modified docstring (Examples section) in singular_values_plot to…
forgi86 0ada3f6
DOC: modified imports in docstring (Examples section) in singular_val…
forgi86 649c394
Merge branch 'master' into pr-593
bnavigator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
TST:
- added a test that generates a plot
- Loading branch information
commit 87d48abc77e5c07f766e64bfac8df8066fd88cf0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also cover the code for the nyquistfreq line and check the correct location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a test that checks this (and also checks the superposition of 2 singular values plot)