Skip to content

CI tests via GitHub actions and conda #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murrayrm merged 10 commits into from
Jan 12, 2021
Merged

CI tests via GitHub actions and conda #504

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3f87c33
Create python-package-conda.yml
murrayrm Jan 10, 2021
21e47a6
remove flake8 lint; add dependencies
murrayrm Jan 10, 2021
d83e67d
skip X11 tests if no DISPLAY env variable
murrayrm Jan 10, 2021
627754f
expand test matrix to match Travis CI
murrayrm Jan 10, 2021
47251c6
simplify GitHub actions workflow
murrayrm Jan 11, 2021
6ff2e9b
pytest with slycot from source
murrayrm Jan 11, 2021
5bb9de4
update xvfb configuration; remove X11 marks
murrayrm Jan 12, 2021
36ecea1
update xvfb configuration; remove X11 marks
murrayrm Jan 12, 2021
b7b696f
add coveralls
murrayrm Jan 12, 2021
40aac67
Merge branch 'github-actions-conda_revised' into github-actions-conda
murrayrm Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify GitHub actions workflow
  • Loading branch information
@murrayrm
murrayrm committed Jan 11, 2021
commit 47251c655276adbd898e01fb2660cdafeaaa9d58
36 changes: 15 additions & 21 deletions .github/workflows/python-package-conda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
max-parallel: 5
matrix:
python-version: [2.7, 3.6, 3.9]
python-version: [3.6, 3.9]
slycot: ["", "conda"]
array-and-matrix: [0]
include:
Expand All @@ -19,34 +19,28 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Set up Python
uses: actions/setup-python@v2
- name: Set up conda
- name: Install dependencies
run: |
# Set up conda
echo $CONDA/bin >> $GITHUB_PATH
conda create -q -n test-environment python=${{matrix.python-version}}
- name: Install dependencies
run: |
source $CONDA/bin/activate test-environment
conda install pip coverage pytest

# Set up (virtual) X11
sudo apt install -y xvfb

# Install test tools
conda install pip coverage pytest
conda install -c conda-forge pytest-xvfb pytest-cov

@bnavigator bnavigator Jan 11, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage not reported to coveralls yet

@murrayrm murrayrm Jan 11, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to merge the PR before this is run and (hopefully) at that point things start to show up in coveralls?

@bnavigator bnavigator Jan 11, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage != coveralls.

See https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-gotcha and my previously linked workflow draft for Slycot. (Much more complicated than yours! :( )


# Install python-control dependencies
conda install numpy matplotlib scipy
if [[ '${{matrix.python-version}}' == '2.7' ]]; then
# matplotlib for Python 2.7 seems to require X11 to run correctly
sudo apt install -y xvfb
if [[ '${{matrix.slycot}}' == 'conda' ]]; then
conda install -c conda-forge slycot
fi
- name: Install slycot via conda (optional)
if: ${{ matrix.slycot == 'conda' }}
run: |
source $CONDA/bin/activate test-environment
conda install -c conda-forge slycot
- name: Test with pytest
env:
PYTHON_CONTROL_ARRAY_AND_MATRIX: ${{ matrix.array-and-matrix }}
run: |
source $CONDA/bin/activate test-environment
if [[ '${{matrix.python-version}}' == '2.7' ]]; then
# Run within (virtual) X11 environment for Python 2.7/matplotlib
xvfb-run pytest control/tests
else
coverage run -m pytest control/tests
fi
xvfb-run --auto-servernum pytest control/tests
Comment thread
murrayrm marked this conversation as resolved.
Outdated