Skip to content

Default dt is 0 #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sawyerbfuller wants to merge 12 commits into from
Closed

Default dt is 0 #431

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0113f99
set default dt to be 0 instead of None. Now need to fix resulting uni…
sawyerbfuller Jul 17, 2020
9aed7cc
changes so that a default dt=0 passes unit tests. fixed code everywhe…
sawyerbfuller Jul 17, 2020
7a9bcd4
small bugfix to xferfcn._evalfr to correctly give it dt value
sawyerbfuller Jul 18, 2020
d59e57a
removed a brittle unit test dependency that is already tested elsewhere
sawyerbfuller Jul 18, 2020
c96465d
improved unit test suggestd by ben greiner
sawyerbfuller Jul 20, 2020
2ec1653
re-incorporated lti.timebaseEqual, with a pendingDeprecationWarning
sawyerbfuller Jul 20, 2020
1e001ee
changes to enable package-wide default, 'control.default_dt')
sawyerbfuller Jul 20, 2020
f5c3fac
fixes to docstrings and conventions.rst to match convention of dt=0 a…
sawyerbfuller Jul 20, 2020
c6787cc
remove extraneous file
sawyerbfuller Jul 21, 2020
606975d
new method is_static_gain() for state space and transfer function sys…
sawyerbfuller Jul 22, 2020
2bd912d
added keyword arguments to xferfcn.tf and statesp.ss to set dt
sawyerbfuller Jul 22, 2020
dc53eb9
unit tests for is_static_gain system method and dt keyword in system …
sawyerbfuller Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improved unit test suggestd by ben greiner
  • Loading branch information
@sawyerbfuller
sawyerbfuller committed Jul 20, 2020
commit c96465dcaa36431d55335f086326c4a23f00bc9f
19 changes: 12 additions & 7 deletions control/tests/discrete_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,18 @@ def test_timebase_conversions(self):
self.assertEqual(timebase(feedback(tf3, tf4)), timebase(tf4))

# Make sure all other combinations are errors
self.assertRaises(ValueError, tf2.__mul__, tf3)
self.assertRaises(ValueError, tf2.__mul__, tf4)
self.assertRaises(ValueError, tf2.__add__, tf3)
self.assertRaises(ValueError, tf2.__add__, tf4)
self.assertRaises(ValueError, tf2.feedback, tf3)
self.assertRaises(ValueError, tf2.feedback, tf4)

with self.assertRaises(ValueError): tf2*tf3
with self.assertRaises(ValueError): tf3*tf2
with self.assertRaises(ValueError): tf2*tf4
with self.assertRaises(ValueError): tf4*tf2
with self.assertRaises(ValueError): tf2+tf3
with self.assertRaises(ValueError): tf3+tf2
with self.assertRaises(ValueError): tf2+tf4
with self.assertRaises(ValueError): tf4+tf2
with self.assertRaises(ValueError): feedback(tf2, tf3)
with self.assertRaises(ValueError): feedback(tf3, tf2)
with self.assertRaises(ValueError): feedback(tf2, tf4)
with self.assertRaises(ValueError): feedback(tf4, tf2)

def testisdtime(self):
# Constant
Expand Down