Skip to content

Switch to pytest and add optional Python 3.8 test #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murrayrm merged 12 commits into from
Mar 25, 2020
Merged

Switch to pytest and add optional Python 3.8 test #380

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a70583b
switch Travis to use pytest instead of deprecated setup.py test
murrayrm Jan 20, 2020
989326d
fix import error in discrete unit test (for pytest)
murrayrm Jan 20, 2020
e4e490c
install pytest for Travis CI
murrayrm Jan 20, 2020
ed8a27b
update Travis pytest to ignore slycot
murrayrm Jan 20, 2020
64adf46
update Travis pytest to ignore slycot, attempt 2
murrayrm Jan 20, 2020
866e9ee
add optional Travis test against python3.8
murrayrm Jan 20, 2020
e25e8b2
add python3.8 testing
murrayrm Jan 20, 2020
263735a
trim python3.8 testing to a single case (for now)
murrayrm Jan 20, 2020
53202aa
remove matrix keyword in travis
bnavigator Mar 18, 2020
c2ade6f
remove unneeded initialization code that was causing problems with py…
murrayrm Mar 22, 2020
1881f9d
fix small typo in test file (probably irrelevent)
murrayrm Mar 22, 2020
aed449d
remove unused (and sometimes incorrect) creation of test suites and r…
murrayrm Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update Travis pytest to ignore slycot, attempt 2
  • Loading branch information
@murrayrm
murrayrm committed Mar 21, 2020
commit 64adf4638952bfe6523de3387d8a944869cb9369
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ install:
# command to run tests
script:
- 'if [ $SLYCOT != "" ]; then python -c "import slycot"; fi'
- coverage run -m pytest -k control/tests --disable-warnings
- coverage run -m pytest --disable-warnings control/tests

@bnavigator bnavigator Mar 21, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is --disable-warnings needed? I would rather have them printed and give every contributor the opportunity to fix problems early before e.g. DeprecationWarnings turn into errors after a Python or some library update.

@murrayrm murrayrm Mar 22, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 18,209 warning messages and unfortunately pytest prints error messages first => I found it hard to locate the errors. Most of the warnings seem to be around the use of numpy.matrix, which I figure we will get rid of starting in v0.9.0.


# only run examples if Slycot is install
# set PYTHONPATH for examples
Expand Down