Skip to content

Improve interface of bdalg.feedback [sf#4] #20

Description

@murrayrm

Reported by eike on 2011-06-13 15:07 UTC
Change the interface of bdalg.feedback to that of Matlab's feedback function. The current interface is too cumbersome for MIMO models.

The function should react differently whether it has 2, 3, 4, or 5 arguments:

Implies: both systems may be MIMO or SISO; sys1.inputs == sys2.outputs; sys2.inputs == sys1.outputs
feedback(sys1, sys2)
feedback(sys1, sys2, sign)

Implies: sys1: MIMO; sys2: SISO
feedback(sys1, sys2, sys1_in, sys1_out)
feedback(sys1, sys2, sys1_in, sys1_out, sign)

See:
http://www.mathworks.com/help/toolbox/control/ref/feedback.html

The implementation should be no big intellectual endeavor, because a general implementation of feedback for MIMO systems already exists.
It just requires work, and a little design (maybe introduce a function siso2mimo).
The current implementation covers the case of 2, and 3 arguments.

Activity

  1. murrayrm commented on Aug 9, 2014

    @murrayrm
    MemberAuthor

    Commented by sf-robot on 2011-07-06 20:20 UTC
    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

  2. changed the title [-]Improve interface of ``bdalg.feedback``[/-] [+]Improve interface of ``bdalg.feedback`` [sf#4][/+] on Aug 9, 2014
  3. self-assigned this
    on Aug 9, 2014
  4. murrayrm commented on Aug 9, 2014

    @murrayrm
    MemberAuthor

    Updated by murrayrm on 2012-09-04 04:59 UTC

    • status: closed --> accepted
    • milestone: --> Next_Release_(example)
  5. murrayrm commented on Aug 9, 2014

    @murrayrm
    MemberAuthor

    Commented by murrayrm on 2012-09-04 04:59 UTC
    This feature got marked as closed by a bot. Should still be open.

  6. removed this from the 0.7.0 milestone on Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions