Skip to content

Support external-dependencies in pyright #9434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 22 commits into from
Jan 3, 2023
Merged

Support external-dependencies in pyright #9434

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2096d1e
Support external-dependencies in pyright
Avasam Dec 31, 2022
a2c3bfd
Conditional install
Avasam Dec 31, 2022
66b8552
install tools first
Avasam Dec 31, 2022
0682f43
Fallback to lru_cache
Avasam Dec 31, 2022
0a81784
install typing_extensions
Avasam Dec 31, 2022
1c05a35
pathspec + packaging
Avasam Dec 31, 2022
a7315e8
Fix pyright dep installs
Avasam Dec 31, 2022
dd9a512
Revert lru_cache shim
Avasam Dec 31, 2022
557f871
Correctly de-duplicate requirements
Avasam Dec 31, 2022
fc61899
Merge branch 'main' into support-non-type-dependency-pyright
AlexWaygood Dec 31, 2022
8766612
Update tests/utils.py
Avasam Dec 31, 2022
87324d4
Revert if TYPE_CHECKING
Avasam Jan 1, 2023
f2f0b8d
Merge branch 'support-non-type-dependency-pyright' of https://github.…
Avasam Jan 1, 2023
1ea0b23
Add doc about installing deps
Avasam Jan 1, 2023
8dd53a2
Apply suggestions from code review
Avasam Jan 1, 2023
807a8f4
Update tests/README.md
Avasam Jan 2, 2023
1ff9c18
Update tests/README.md
Avasam Jan 2, 2023
5abb5e1
Oops another typo
AlexWaygood Jan 2, 2023
dfa4085
Rename scripts
Avasam Jan 2, 2023
b5a2495
Add some random non-types dependencies to see what happens
AlexWaygood Jan 3, 2023
fad4c7c
Revert "Add some random non-types dependencies to see what happens"
AlexWaygood Jan 3, 2023
a89c681
Reflow docs to keep line length <90 characters where practical
AlexWaygood Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename scripts
  • Loading branch information
@Avasam
Avasam committed Jan 2, 2023
commit dfa4085f5d19c2cdaa2903ed7abd53c2ff684805
2 changes: 1 addition & 1 deletion .github/workflows/daily.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
- name: Run stubtest
shell: bash
run: |
PACKAGES=$(python tests/get_packages.py)
PACKAGES=$(python tests/get_stubtest_system_requirements.py)

if [ "${{ runner.os }}" = "Linux" ]; then
if [ -n "$PACKAGES" ]; then
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stubtest_third_party.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:

if [ -n "$STUBS" ]; then
echo "Testing $STUBS..."
PACKAGES=$(python tests/get_packages.py $STUBS)
PACKAGES=$(python tests/get_stubtest_system_requirements.py $STUBS)

if [ "${{ runner.os }}" = "Linux" ]; then
if [ -n "$PACKAGES" ]; then
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ jobs:
- name: Install 3rd-party dependencies for stubs packages
run: |
pip install -r requirements-tests.txt
DEPENDENCIES=$(python tests/get_external_dependencies.py)
DEPENDENCIES=$(python tests/get_external_stub_requirements.py)
if [ -n "$DEPENDENCIES" ]; then
echo "Installing packages: $DEPENDENCIES"
pip install $DEPENDENCIES
Comment thread
Avasam marked this conversation as resolved.
Expand Down
10 changes: 5 additions & 5 deletions tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ the stubs in typeshed (including the standard library).
In order for `pyright_test` to work correctly, some third-party stubs may require dependencies external to typeshed to be installed in your virtual environment prior to running the test.
You can list or install all of a stubs package's external dependencies using the following script:
```bash
Comment thread
AlexWaygood marked this conversation as resolved.
(.venv3)$ python tests/get_external_dependencies.py <third_party_stub> # List external dependencies for <third_party_stub>
(.venv3)$ python tests/get_external_dependencies.py <third_party_stub1> <third_party_stub2> # List external dependencies for <third_party_stub1> and <third_party_stub2>
(.venv3)$ python tests/get_external_dependencies.py # List external dependencies for all third-party packages in typeshed
# Install external dependencies for all third-party stubs packages in typeshed
(.venv3)$ DEPENDENCIES=$(python tests/get_external_dependencies.py)
(.venv3)$ python tests/get_external_stub_requirements.py <third_party_stub> # List external dependencies for <third_party_stub>
(.venv3)$ python tests/get_external_stub_requirements.py <third_party_stub1> <third_party_stub2> # List external dependencies for <third_party_stub1> and <third_party_stub2>
(.venv3)$ python tests/get_external_stub_requirements.py # List external dependencies for all third-party stubs in typeshed
# Install external dependencies for all third-party stubs in typeshed
(.venv3)$ DEPENDENCIES=$(python tests/get_external_stub_requirements.py)
(.venv3)$ if [ -n "$DEPENDENCIES" ]; then pip install $DEPENDENCIES; fi
```

Expand Down
0 tests/get_external_dependencies.py → tests/get_external_stub_requirements.py
View file
Open in desktop
File renamed without changes.
0 tests/get_packages.py → tests/get_stubtest_system_requirements.py
100755 → 100644
View file
Open in desktop
File renamed without changes.