Skip to content

Support external-dependencies in pyright #9434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 22 commits into from
Jan 3, 2023
Merged

Support external-dependencies in pyright #9434

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2096d1e
Support external-dependencies in pyright
Avasam Dec 31, 2022
a2c3bfd
Conditional install
Avasam Dec 31, 2022
66b8552
install tools first
Avasam Dec 31, 2022
0682f43
Fallback to lru_cache
Avasam Dec 31, 2022
0a81784
install typing_extensions
Avasam Dec 31, 2022
1c05a35
pathspec + packaging
Avasam Dec 31, 2022
a7315e8
Fix pyright dep installs
Avasam Dec 31, 2022
dd9a512
Revert lru_cache shim
Avasam Dec 31, 2022
557f871
Correctly de-duplicate requirements
Avasam Dec 31, 2022
fc61899
Merge branch 'main' into support-non-type-dependency-pyright
AlexWaygood Dec 31, 2022
8766612
Update tests/utils.py
Avasam Dec 31, 2022
87324d4
Revert if TYPE_CHECKING
Avasam Jan 1, 2023
f2f0b8d
Merge branch 'support-non-type-dependency-pyright' of https://github.…
Avasam Jan 1, 2023
1ea0b23
Add doc about installing deps
Avasam Jan 1, 2023
8dd53a2
Apply suggestions from code review
Avasam Jan 1, 2023
807a8f4
Update tests/README.md
Avasam Jan 2, 2023
1ff9c18
Update tests/README.md
Avasam Jan 2, 2023
5abb5e1
Oops another typo
AlexWaygood Jan 2, 2023
dfa4085
Rename scripts
Avasam Jan 2, 2023
b5a2495
Add some random non-types dependencies to see what happens
AlexWaygood Jan 3, 2023
fad4c7c
Revert "Add some random non-types dependencies to see what happens"
AlexWaygood Jan 3, 2023
a89c681
Reflow docs to keep line length <90 characters where practical
AlexWaygood Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert lru_cache shim
  • Loading branch information
@Avasam
Avasam committed Dec 31, 2022
commit dd9a512d8a89c802fe52cb52600bb1119b73c265
10 changes: 2 additions & 8 deletions tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
import subprocess
import sys
import venv
from collections.abc import Iterable, Mapping
from functools import cache
from pathlib import Path
from typing import TYPE_CHECKING, NamedTuple

Expand All @@ -15,7 +17,6 @@
from packaging.requirements import Requirement

if TYPE_CHECKING:
Comment thread
AlexWaygood marked this conversation as resolved.
Outdated
from collections.abc import Iterable, Mapping
from typing_extensions import Annotated

try:
Expand All @@ -26,13 +27,6 @@ def colored(text: str, color: str | None = None, on_color: str | None = None, at
return text


if sys.version_info >= (3, 9):
from functools import cache
else:
from functools import lru_cache

cache = lru_cache(maxsize=None)

# Used to install system-wide packages for different OS types:
METADATA_MAPPING = {"linux": "apt_dependencies", "darwin": "brew_dependencies", "win32": "choco_dependencies"}

Expand Down