Repository navigation
bpo-27099: IDLE - Convert built-in extensions to regular features #2494
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ def __init__(self, editwin=None): | |
| self._delayed_completion_index = None | ||
|
|
||
| def reset(self): | ||
| self.popupwait = idleConf.GetOption("main", "General", | ||
| "autocomplete_wait", type="int", default=0) | ||
|
|
||
|
Member
There was a problem hiding this comment. One-liner is not worth a separate function.
Contributor
Author
There was a problem hiding this comment. Built-in options are effective when they are changed from the config menu. Extensions require restarting IDLE. In order for these to function like built-ins, their changed settings needed to be reloaded from within the editor. That is what the reset function is for. There is one in each of the old extensions that had options. It seems the activation got lost when I was resolving conflicts, but it looks like the place to call it is now activate_config_changes in the configdialog. Would you rather I put the functionality back in, or that some of the new options behave differently than the old ones?
Member
There was a problem hiding this comment. I opened bpo-22707 two years ago for this problem, and intended that we work on it after this one. I just posted my analysis and made you nosy. For reasons explained there, I want to leave the class attributes as class attributes. Whether the idleConf wrapper are added here or in 22707, they should be called 'reload'; 'reset' implies changing back to initial values. They should be classmethods called after the class statement. This will preserve the current behavior, which I will manually test. The line length for ReformatParagraph should be a class attribute, and the test adjusted. CodeContext().visible should be left alone until fixed or deleted. I want to deal with changing code to update immediately in 22707, where the new code will be tested. I will add more on that issue. |
||
| def _make_autocomplete_window(self): | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want these to be class methods called after the class is created. I will fix for all 4 files. I also changed back to original args -- 'extensions', 'AutoComplete', 'popupwait'.