Skip to content

bpo-27099: IDLE - Convert built-in extensions to regular features #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 56 commits into from
Sep 10, 2017
Merged

bpo-27099: IDLE - Convert built-in extensions to regular features #2494

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
5c57faf
parenmatch highlighting options
wohlganger Jun 29, 2017
d49170f
fixed whitespace issue
wohlganger Jun 29, 2017
8c3a966
only select from highlighting options
wohlganger Jun 30, 2017
757bb38
fixed whitespace
wohlganger Jun 30, 2017
d7e136c
whitespace
wohlganger Jun 30, 2017
b178af5
Merge remote-tracking branch 'upstream/master'
wohlganger Jul 10, 2017
2adebb9
#27099 - turn builtin extensions to reg modules
wohlganger Jul 10, 2017
86c3d4c
whitespace + fix I thought I already committed.
wohlganger Jul 10, 2017
1c246fc
warning fixes, removed old config entries
wohlganger Jul 11, 2017
0418ad0
calltip append doc fix, default paren-fore fix, help update
wohlganger Jul 11, 2017
097a0d8
fix calltips
wohlganger Jul 12, 2017
4232e77
removed circular import
wohlganger Jul 12, 2017
a7b29f5
fix warnings due to missing default config options in idlelib.config-…
wohlganger Jul 12, 2017
e30b7b4
Merge branch 'master' into master
wohlganger Jul 17, 2017
252672b
added format_pmaxw to config-main
wohlganger Jul 19, 2017
999b573
Merge remote-tracking branch 'upstream/master'
wohlganger Jul 19, 2017
1a74591
replaced help.html edit with idle.rst edit
wohlganger Jul 20, 2017
3501c45
Merge branch 'master' into master
wohlganger Jul 24, 2017
232f711
Merge remote-tracking branch 'upstream/master'
wohlganger Aug 4, 2017
f095c53
added conflict resolved var descriptions to docstring in create_page_…
wohlganger Aug 4, 2017
a661bfa
strip trailing whitespace
wohlganger Aug 4, 2017
5c90a8f
Merge branch 'master' into master
wohlganger Aug 24, 2017
5a6a007
re-introduced highlight options.
wohlganger Aug 24, 2017
709b434
News blurb.
terryjreedy Aug 24, 2017
b9b1f9a
Reinstated zoomheight as an extension. Replaced autoexpand with zoomh…
wohlganger Aug 24, 2017
8b76ccb
fixed configdialog test (wrong cases), fixed whitespace
wohlganger Aug 24, 2017
b986c12
update idle.rst: zoomheight is an extension.
wohlganger Aug 24, 2017
f86acaa
more fixes for zoomheight - trying to minimize changes from master
wohlganger Aug 24, 2017
5805462
zoomheight config fix, zoomheight should be fully back to the way it …
wohlganger Aug 24, 2017
165b548
whitespace
wohlganger Aug 24, 2017
aee5d02
fixed force-open completions missing from config-keys and config. Fix…
wohlganger Aug 24, 2017
cb161bd
Changes made per terryjreedy request.
wohlganger Aug 25, 2017
dc09a2b
re-added autocomplete wait and format paragraph max width options to …
wohlganger Aug 25, 2017
100463e
Merge branch 'master' into master
wohlganger Aug 28, 2017
3fbaa90
Merge branch 'master' into master
wohlganger Aug 30, 2017
60ff82f
changes per terryjreedy
wohlganger Aug 30, 2017
e3f6f16
fix warnings, errors, bugs
wohlganger Aug 30, 2017
a253f0c
whitespace
wohlganger Aug 30, 2017
fe8eb7a
bugfix
wohlganger Aug 30, 2017
caa7774
Make changes need to get IDLE to run
terryjreedy Aug 31, 2017
c29184e
Edit extension/feature files, making existing tests pass.
terryjreedy Aug 31, 2017
c62f726
Redo feature bindings.
terryjreedy Aug 31, 2017
d0e009f
First draft of dummy extension.
terryjreedy Aug 31, 2017
9e889c2
Fix that eliminate startup error and all but 2 test_idle errors.
terryjreedy Aug 31, 2017
6afdea3
Move widgets, load widgets, add tests, make previous tests pass.
terryjreedy Sep 2, 2017
7de27db
Add format-paragraph to core keys.
terryjreedy Sep 5, 2017
a2e76a7
Merge remote-tracking branch 'origin/master' into pr_2494
terryjreedy Sep 5, 2017
2265b53
Fix autocomplete and long lines.
terryjreedy Sep 5, 2017
03eed24
Put fixed-key event-adds in EditorWindow.__init__ for now.
terryjreedy Sep 9, 2017
207b0ca
Don't warn if new core keys not in user key config.
terryjreedy Sep 9, 2017
00acd22
Make code context inoperative in outwin, shell.
terryjreedy Sep 9, 2017
2d2bfbd
Change new bindings for MacOsx.
terryjreedy Sep 9, 2017
fe76cd3
Disable test dependent on extension Alt keys.
terryjreedy Sep 9, 2017
d2966e0
Minor edits.
terryjreedy Sep 9, 2017
6845bb0
File out news blurb explaining effect for users.
terryjreedy Sep 10, 2017
b7afebb
Don't compute ('') during integer input in entry box.
terryjreedy Sep 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
calltip append doc fix, default paren-fore fix, help update 
How did the change to the __doc__ of append not get fixed in the tests earlier?
  • Loading branch information
@wohlganger
wohlganger committed Jul 11, 2017
commit 0418ad0a94f215ad9b5894b9e5b71474670f5c44
2 changes: 1 addition & 1 deletion Lib/idlelib/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def GetThemeDict(self, type, themeName):
'console-background':'#ffffff',
'codecontext-foreground':'#000000',
'codecontext-background':'#ffffff',
'parenmatch-foreground':'000000',
'parenmatch-foreground':'#000000',
'parenmatch-background':'#ffffff',

@terryjreedy terryjreedy Aug 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete parenmatch.

}
for element in theme:
Expand Down
15 changes: 2 additions & 13 deletions Lib/idlelib/help.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,19 +636,8 @@ <h3>25.5.4.2. Setting preferences<a class="headerlink" href="#setting-preference
<h3>25.5.4.3. Extensions<a class="headerlink" href="#extensions" title="Permalink to this headline">¶</a></h3>
<p>IDLE contains an extension facility. Preferences for extensions can be
changed with Configure Extensions. See the beginning of config-extensions.def
in the idlelib directory for further information. The default extensions
are currently:</p>
<ul class="simple">
<li>FormatParagraph</li>
<li>AutoExpand</li>
<li>ZoomHeight</li>
<li>ScriptBinding</li>
<li>CallTips</li>
<li>ParenMatch</li>
<li>AutoComplete</li>
<li>CodeContext</li>
<li>RstripExtension</li>
</ul>
in the idlelib directory for further information. There are currently no default extensions.</p>

@terryjreedy terryjreedy Jul 19, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help.html is generated from Doc/library/idle.rst. So replace this edit with an edit of the latter. I believe it should be straightforward.

</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion Lib/idlelib/idle_test/test_calltips.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def gtest(obj, out):
'Create and return a new object. See help(type) for accurate signature.')
gtest(list.__init__,
'Initialize self. See help(type(self)) for accurate signature.')
append_doc = "Append object to the end of the list."
append_doc = "L.append(object) -> None -- append object to end"
gtest(list.append, append_doc)
gtest([].append, append_doc)
gtest(List.append, append_doc)
Expand Down