Skip to content

bpo-38671: Make sure to return an absolute path in pathlib._WindowsFlavour.resolve() #17716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uranusjr wants to merge 5 commits into from
Closed

bpo-38671: Make sure to return an absolute path in pathlib._WindowsFlavour.resolve() #17716

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e503cd6
Prepend cwd if resolve can't find existing prefix
uranusjr Dec 27, 2019
3f9d1b8
Use os.path.abspath() as fallback as suggested
uranusjr Jul 15, 2020
612b7f6
Use early returns to reduce indentation level
uranusjr Jul 15, 2020
7cff82e
Test non-exist resolve on all platforms
uranusjr Jul 19, 2020
8f20c10
Use nt._getfullpathname instead of os.path.abspath
uranusjr Jul 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use nt._getfullpathname instead of os.path.abspath
  • Loading branch information
@uranusjr
uranusjr committed Apr 27, 2021
commit 8f20c10011e42757a881e1bbdd8f929ef144b458
7 changes: 4 additions & 3 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@


if os.name == 'nt':
from nt import _getfinalpathname
from nt import _getfinalpathname, _getfullpathname
else:
_getfinalpathname = None

Expand Down Expand Up @@ -194,7 +194,7 @@ def resolve(self, path, strict=False):
return None # Means fallback on absolute
Comment thread
uranusjr marked this conversation as resolved.
Outdated
if strict:

@eryksun eryksun Oct 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 189-191 make a bad assumption that the current working directory (CWD) is a final path. The CWD is an absolute path but not a final path. The assignment should be something like s = str(path) or '.'. In practice it may never be an issue since PurePath.__str__ assigns and returns self._str = self._format_parsed_parts(self._drv, self._root, self._parts) or '.'.

@uranusjr uranusjr Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CWD is an absolute path but not a final path.

TIL.

I like the or '.' approach since it avoids special-casing things, but want @pitrou to take a look since this is inherited from the initial pathlib implementation.

return self._ext_to_normal(_getfinalpathname(s))
s = path = os.path.abspath(s)
s = path = _getfullpathname(s)
previous_s = None
tail_parts = [] # End of the path after the first one not found
while True:
Expand All @@ -204,7 +204,8 @@ def resolve(self, path, strict=False):
previous_s = s
s, tail = os.path.split(s)
tail_parts.append(tail)
if previous_s == s: # Root reached, fallback to abspath()
if previous_s == s:
# Root reached, fallback to _getfullpathname()
return path
else:
return os.path.join(s, *reversed(tail_parts))
Expand Down