Skip to content

bpo-38671: Make sure to return an absolute path in pathlib._WindowsFlavour.resolve() #17716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uranusjr wants to merge 5 commits into from
Closed

bpo-38671: Make sure to return an absolute path in pathlib._WindowsFlavour.resolve() #17716

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e503cd6
Prepend cwd if resolve can't find existing prefix
uranusjr Dec 27, 2019
3f9d1b8
Use os.path.abspath() as fallback as suggested
uranusjr Jul 15, 2020
612b7f6
Use early returns to reduce indentation level
uranusjr Jul 15, 2020
7cff82e
Test non-exist resolve on all platforms
uranusjr Jul 19, 2020
8f20c10
Use nt._getfullpathname instead of os.path.abspath
uranusjr Jul 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test non-exist resolve on all platforms
  • Loading branch information
@uranusjr
uranusjr committed Apr 27, 2021
commit 7cff82ea1b9b44310343fa617596a1c6426dd553
20 changes: 10 additions & 10 deletions Lib/test/test_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1799,6 +1799,16 @@ def test_resolve_dot(self):
# Non-strict
self.assertEqual(r.resolve(strict=False), p / '3' / '4')

def test_resolve_nonexist_relative_issue38671(self):
p = self.cls('non', 'exist')

old_cwd = os.getcwd()
os.chdir(BASE)
try:
self.assertEqual(p.resolve(), self.cls(BASE, p))
finally:
os.chdir(old_cwd)

def test_with(self):
p = self.cls(BASE)
it = p.iterdir()
Expand Down Expand Up @@ -2654,16 +2664,6 @@ def check():
env['HOME'] = 'C:\\Users\\eve'
check()

def test_resolve_nonexist_relative_issue38671(self):
p = self.cls('non', 'exist')

old_cwd = os.getcwd()
os.chdir(BASE)
try:
self.assertEqual(p.resolve(), self.cls(BASE, p))
finally:
os.chdir(old_cwd)


class CompatiblePathTest(unittest.TestCase):
"""
Expand Down