Skip to content

gh-142889: Improve layout of dictionary keys #150640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brijkapadia wants to merge 14 commits into
base: main
Choose a base branch
from
+167 −80
Open

gh-142889: Improve layout of dictionary keys #150640

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f7f967e
gh-142889: Improve layout of dictionary keys
brijkapadia May 30, 2026
66659cf
📜🤖 Added by blurb_it.
blurb-it[bot] May 30, 2026
13b8d7e
update union
brijkapadia May 30, 2026
4476844
Update test/gdb
brijkapadia May 31, 2026
fce9aa9
update sizeof calculation
brijkapadia May 31, 2026
1c0ee1b
Apply suggestions from code review
brijkapadia Jun 19, 2026
ae9ad1d
Merge remote-tracking branch 'upstream/main' into dict-keys
brijkapadia Jun 26, 2026
708bbae
fix const test
brijkapadia Jun 26, 2026
3c15497
Merge remote-tracking branch 'upstream/main' into dict-keys
brijkapadia Jul 8, 2026
3be6705
small changes
brijkapadia Jul 8, 2026
398e7c8
fix error
brijkapadia Jul 8, 2026
a265605
Merge remote-tracking branch 'upstream' into dict-keys
brijkapadia Jul 23, 2026
d11a0c7
small changes
brijkapadia Jul 23, 2026
8c99391
Merge remote-tracking branch 'upstream' into dict-keys
brijkapadia Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update sizeof calculation
  • Loading branch information
@brijkapadia
brijkapadia committed May 31, 2026
commit fce9aa9179d6b98a269a7c432b9c9b69646e8f98
2 changes: 1 addition & 1 deletion Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5058,7 +5058,7 @@ _PyDict_KeysSize(PyDictKeysObject *keys)
{
size_t es = (keys->dk_kind == DICT_KEYS_GENERAL
? sizeof(PyDictKeyEntry) : sizeof(PyDictUnicodeEntry));
size_t size = sizeof(PyDictKeysObject);
size_t size = sizeof(PyDictKeysObject) - sizeof(PyDictKeyEntry);
size += (size_t)1 << keys->dk_log2_index_bytes;
size += USABLE_FRACTION((size_t)DK_SIZE(keys)) * es;
return size;
Expand Down
Loading