small changes

brijkapadia · May 30, 2026 · May 30, 2026 · May 30, 2026 · May 31, 2026 · May 31, 2026
commit 3be6705523a6a2b54570c4873652143e119dd711
diff --git a/Include/internal/pycore_dict.h b/Include/internal/pycore_dict.h
@@ -226,6 +226,7 @@ struct _dictkeysobject {
     } dk_entries;
 };
 
+/* The _dictkeysobject is allocated directly afterwards */
 struct _instancekeysobject {
     PyTypeObject* dsk_owning_type;
 };

@@ -857,8 +857,7 @@
     dk->dk_nentries = 0;
     dk->dk_usable = usable;
     dk->dk_version = 0;
-    size_t indices_size = (size_t)1 << log2_bytes;
-    memset(_DK_INDICES(dk), 0xff, indices_size);
+    memset(_DK_INDICES(dk), 0xff, ((size_t)1 << log2_bytes));
     memset(_DK_ENTRIES(dk), 0, entry_size * usable);
 }
 
@@ -7282,22 +7281,20 @@
 {
     int log2_bytes = get_log2_bytes(NEXT_LOG2_SHARED_KEYS_MAX_SIZE);
     Py_ssize_t usable = USABLE_FRACTION((size_t)1<<NEXT_LOG2_SHARED_KEYS_MAX_SIZE);
-    size_t indices_size = (size_t)1 << log2_bytes;
-    size_t keys_size = sizeof(PyDictKeysObject) - sizeof(PyDictKeyEntry)
-                     + sizeof(PyDictUnicodeEntry) * usable;
 
     struct _instancekeysobject *shared_keys =
                           PyMem_Malloc(sizeof(struct _instancekeysobject)
-                          + indices_size
-                          + keys_size);
+                          + ((size_t)1 << log2_bytes)
+                          + sizeof(PyDictKeysObject) - sizeof(PyDictKeyEntry)
+                          + sizeof(PyDictUnicodeEntry) * usable);
     if (shared_keys == NULL) {
         PyErr_Clear();
         return NULL;
    }

    shared_keys->dsk_owning_type = (PyTypeObject *)cls;
    PyDictKeysObject* keys = _DK_FROM_BASE((char *)shared_keys + sizeof(struct _instancekeysobject),
                                           indices_size);
    init_keys_object(keys, NEXT_LOG2_SHARED_KEYS_MAX_SIZE, log2_bytes, DICT_KEYS_SPLIT,
                     SHARED_KEYS_MAX_SIZE, sizeof(PyDictUnicodeEntry));
    assert(keys->dk_nentries == 0);