Skip to content

gh-149738: Fix segmentation fault bug in sqllite3 #149754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 18 commits into from
Jun 2, 2026
Merged

gh-149738: Fix segmentation fault bug in sqllite3 #149754

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
388090c
Fix segfault bug in connection.c
sepehr-rs May 13, 2026
3da9d0e
Add news entry
sepehr-rs May 13, 2026
6f4faa3
Add tests
sepehr-rs May 13, 2026
cdee382
Merge branch 'main' into fix-149738
sepehr-rs May 21, 2026
a0d272a
Update connection.c to raise an exception when trying to delete row_f…
sepehr-rs May 21, 2026
5c64a63
Update test_delete_connection_row_factory to reflect new changes
sepehr-rs May 21, 2026
4d75cf9
Fix linting issues
sepehr-rs May 21, 2026
20ab789
Update connection.c
sepehr-rs May 21, 2026
b36aa69
Add a test for text_factory
sepehr-rs May 21, 2026
0d6c3ae
Fix linting problems
sepehr-rs May 21, 2026
6920132
Update news file
sepehr-rs May 21, 2026
7cce0ad
Merge branch 'main' into fix-149738
sepehr-rs May 27, 2026
bd81a8e
Update docs
sepehr-rs May 30, 2026
1aede26
Update connection.c
sepehr-rs May 30, 2026
030aa69
Change 3.16 to next
sepehr-rs Jun 1, 2026
33cb091
Merge branch 'main' into fix-149738
sepehr-rs Jun 1, 2026
5489c45
Update docs
sepehr-rs Jun 1, 2026
86f7183
Merge branch 'main' into fix-149738
sepehr-rs Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix linting issues
  • Loading branch information
@sepehr-rs
sepehr-rs committed May 21, 2026
commit 4d75cf9739b751cdfc8e3e193fa9a278f42fa9fe
8 changes: 4 additions & 4 deletions Modules/_sqlite/connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ static int
connection_set_row_factory(pysqlite_Connection *self, PyObject *value, void *closure)
{
if (value == NULL) {
PyErr_SetString(PyExc_AttributeError,
PyErr_SetString(PyExc_AttributeError,
"cannot delete row_factory attribute");
return -1;
}
Expand All @@ -551,7 +551,7 @@ static int
connection_set_text_factory(pysqlite_Connection *self, PyObject *value, void *closure)
Comment thread
sepehr-rs marked this conversation as resolved.
Outdated
{
if (value == NULL) {
PyErr_SetString(PyExc_AttributeError,
PyErr_SetString(PyExc_AttributeError,
"cannot delete text_factory attribute");
return -1;
}
Expand Down Expand Up @@ -2655,9 +2655,9 @@ static PyGetSetDef connection_getset[] = {
{"in_transaction", pysqlite_connection_get_in_transaction, NULL},
{"autocommit", get_autocommit, set_autocommit},
{"__text_signature__", get_sig, NULL},
{"row_factory", (getter)connection_get_row_factory,
{"row_factory", (getter)connection_get_row_factory,
(setter)connection_set_row_factory},
{"text_factory", (getter)connection_get_text_factory,
{"text_factory", (getter)connection_get_text_factory,
(setter)connection_set_text_factory},
{NULL}
};
Expand Down
Loading