Skip to content

gh-149738: Fix segmentation fault bug in sqllite3 #149754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 18 commits into from
Jun 2, 2026
Merged

gh-149738: Fix segmentation fault bug in sqllite3 #149754

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
388090c
Fix segfault bug in connection.c
sepehr-rs May 13, 2026
3da9d0e
Add news entry
sepehr-rs May 13, 2026
6f4faa3
Add tests
sepehr-rs May 13, 2026
cdee382
Merge branch 'main' into fix-149738
sepehr-rs May 21, 2026
a0d272a
Update connection.c to raise an exception when trying to delete row_f…
sepehr-rs May 21, 2026
5c64a63
Update test_delete_connection_row_factory to reflect new changes
sepehr-rs May 21, 2026
4d75cf9
Fix linting issues
sepehr-rs May 21, 2026
20ab789
Update connection.c
sepehr-rs May 21, 2026
b36aa69
Add a test for text_factory
sepehr-rs May 21, 2026
0d6c3ae
Fix linting problems
sepehr-rs May 21, 2026
6920132
Update news file
sepehr-rs May 21, 2026
7cce0ad
Merge branch 'main' into fix-149738
sepehr-rs May 27, 2026
bd81a8e
Update docs
sepehr-rs May 30, 2026
1aede26
Update connection.c
sepehr-rs May 30, 2026
030aa69
Change 3.16 to next
sepehr-rs Jun 1, 2026
33cb091
Merge branch 'main' into fix-149738
sepehr-rs Jun 1, 2026
5489c45
Update docs
sepehr-rs Jun 1, 2026
86f7183
Merge branch 'main' into fix-149738
sepehr-rs Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change 3.16 to next
  • Loading branch information
@sepehr-rs
sepehr-rs authored Jun 1, 2026
commit 030aa69df91ab0f5555408a0ed6098f16146f8c9
6 changes: 3 additions & 3 deletions Doc/library/sqlite3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,7 +1417,7 @@ Connection objects

See :ref:`sqlite3-howto-row-factory` for more details.

.. versionchanged:: 3.16
.. versionchanged:: next
Deleting the ``row_factory`` attribute is no longer allowed and raises
:exc:`AttributeError`.

@vstinner vstinner Jun 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that it's worth it to document this minor behavior. I'm not sure that it's useful to mention the exact exception (AttributeError).

@sepehr-rs sepehr-rs Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback.
I've simplified the versionchanged note and removed the mention of the specific exception. I kept the note itself since this is a user-visible behavior change, but I'm open to removing it if you think it's not necessary.


Expand All @@ -1430,7 +1430,7 @@ Connection objects

See :ref:`sqlite3-howto-encoding` for more details.

.. versionchanged:: 3.16
.. versionchanged:: next
Deleting the ``text_factory`` attribute is no longer allowed and raises
:exc:`AttributeError`.

Expand Down Expand Up @@ -1717,7 +1717,7 @@ Cursor objects

See :ref:`sqlite3-howto-row-factory` for more details.

.. versionchanged:: 3.16
.. versionchanged:: next
Deleting the ``row_factory`` attribute is no longer allowed and raises
:exc:`AttributeError`.

Expand Down