Skip to content

gh-124529: Fix _strptime to make %c/%x accept a year with fewer digits #124778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zuo wants to merge 26 commits into
base: main
Choose a base branch
from
Open

gh-124529: Fix _strptime to make %c/%x accept a year with fewer digits #124778

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
827db45
gh-124529: Fix _strptime to make %c/%x accept year with fewer digits
zuo Sep 30, 2024
1d916a0
Add the blurb
zuo Sep 30, 2024
a4ba3c9
Fix/improve (and shorten) the blurb
zuo Sep 30, 2024
cef0722
Fix/improve/refactor tests and restrict their scope
zuo Sep 30, 2024
6556bdf
Test fail message fixes
zuo Sep 30, 2024
56c84dc
Continue enhancing/improving tests
zuo Sep 30, 2024
b42783c
Improve docstring
zuo Sep 30, 2024
97b523e
Add a suitable mention in the docs + improve blurb
zuo Sep 30, 2024
6c2addf
Docstring edit
zuo Sep 30, 2024
fb32c03
Edit the mention in the docs
zuo Sep 30, 2024
722efe4
Minor docs edit
zuo Sep 30, 2024
7b46a48
Fix/improve tests
zuo Oct 1, 2024
3d4116a
Shorten blurb again
zuo Oct 1, 2024
8eac106
Minor docs edit
zuo Oct 1, 2024
1956662
Docstring edit
zuo Oct 1, 2024
a77c3da
Docs edit
zuo Oct 1, 2024
b3b161f
Docstring edit
zuo Oct 1, 2024
949e66a
Minor test improvements/refactoring
zuo Oct 1, 2024
059d4c5
Add `time.strptime()`-dedicated test
zuo Oct 1, 2024
95753ac
Minor test improvements/refactoring
zuo Oct 1, 2024
ed4582b
Merge branch 'main' into strptime-c-and-y-fix
zuo Oct 1, 2024
990b075
Minor test improvement
zuo Oct 1, 2024
ecc359d
Test improvements/refactoring
zuo Oct 1, 2024
6d690ca
Minor refactoring
zuo Oct 1, 2024
4ad1062
Merge branch 'main' into strptime-c-and-y-fix
zuo Oct 1, 2024
c79a66b
Apply suggestion from @donbarbos
zuo Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor docs edit
  • Loading branch information
@zuo
zuo committed Oct 1, 2024
commit 8eac1067da9826b8318a6ce6ff4e598f9d86c4d2
6 changes: 3 additions & 3 deletions Doc/library/datetime.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2640,9 +2640,9 @@ Notes:
input to be zero-padded to the usual width (which is either 4 or
2 digits, depending on the format code and current locale). In
previous versions, a :exc:`ValueError` was raised if a shorter
*year*, not zero-padded to the 2- or 4-digit width as appropriate,
was part of the input (and it is worth noting that, depending
on the platform/locale, such inputs may be produced by using
*year* (not zero-padded to the 2- or 4-digit width as appropriate)
was part of the input. It is worth noting that, depending on the
platform/locale, such inputs may be produced by using
:meth:`~.datetime.strftime` with ``%c`` or ``%x``).

(2)
Expand Down