Skip to content

gh-124529: Fix _strptime to make %c/%x accept a year with fewer digits #124778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zuo wants to merge 26 commits into
base: main
Choose a base branch
from
Open

gh-124529: Fix _strptime to make %c/%x accept a year with fewer digits #124778

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
827db45
gh-124529: Fix _strptime to make %c/%x accept year with fewer digits
zuo Sep 30, 2024
1d916a0
Add the blurb
zuo Sep 30, 2024
a4ba3c9
Fix/improve (and shorten) the blurb
zuo Sep 30, 2024
cef0722
Fix/improve/refactor tests and restrict their scope
zuo Sep 30, 2024
6556bdf
Test fail message fixes
zuo Sep 30, 2024
56c84dc
Continue enhancing/improving tests
zuo Sep 30, 2024
b42783c
Improve docstring
zuo Sep 30, 2024
97b523e
Add a suitable mention in the docs + improve blurb
zuo Sep 30, 2024
6c2addf
Docstring edit
zuo Sep 30, 2024
fb32c03
Edit the mention in the docs
zuo Sep 30, 2024
722efe4
Minor docs edit
zuo Sep 30, 2024
7b46a48
Fix/improve tests
zuo Oct 1, 2024
3d4116a
Shorten blurb again
zuo Oct 1, 2024
8eac106
Minor docs edit
zuo Oct 1, 2024
1956662
Docstring edit
zuo Oct 1, 2024
a77c3da
Docs edit
zuo Oct 1, 2024
b3b161f
Docstring edit
zuo Oct 1, 2024
949e66a
Minor test improvements/refactoring
zuo Oct 1, 2024
059d4c5
Add `time.strptime()`-dedicated test
zuo Oct 1, 2024
95753ac
Minor test improvements/refactoring
zuo Oct 1, 2024
ed4582b
Merge branch 'main' into strptime-c-and-y-fix
zuo Oct 1, 2024
990b075
Minor test improvement
zuo Oct 1, 2024
ecc359d
Test improvements/refactoring
zuo Oct 1, 2024
6d690ca
Minor refactoring
zuo Oct 1, 2024
4ad1062
Merge branch 'main' into strptime-c-and-y-fix
zuo Oct 1, 2024
c79a66b
Apply suggestion from @donbarbos
zuo Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Docstring edit
  • Loading branch information
@zuo
zuo committed Oct 1, 2024
commit 195666217a8172b7de7906ef8b9b9e88d2f30f9f
13 changes: 7 additions & 6 deletions Lib/_strptime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,14 +241,15 @@ def __pattern_with_lax_year(self, format):

Necessary to ensure that strptime() is able to parse strftime()'s
output when %c or %x is used -- considering that for some locales
and platforms (e.g., 'C.UTF-8' on Linux), formatting with either
%c or %x may produce a year number representation that is shorter
than the usual four or two digits, if the number is small enough
(e.g., '999' rather than `0999', or '9' rather than of '09').
and platforms (e.g., 'C.UTF-8' on Linux) formatting with either
%c or %x may produce a year number representation which is *not*
zero-padded and, consequently (if the number is small enough),
shorter than the usual four or two digits (e.g., '999' rather
than `0999', or '9' rather than of '09').

Note that this helper is intended to be used to prepare regex
patterns only for the `%c` and `%x` format codes (and *not* for
`%y`, `%Y` or `%G`).
patterns *only* for the `%c` and `%x` format codes (and *not*
for `%y`, `%Y` or `%G`).

"""
pattern = self.pattern(format)
Expand Down