Skip to content

Tests: remove C API tests using @requires_legacy_unicode_capi()? #109050

Description

@vstinner

The @test.support.requires_legacy_unicode_capi() decorators uses from _testcapi import unicode_legacy_string, but this module attribute has been remove since Python 3.12 by commit f9c9354, and so all tests using the decorator are now always skipped.

Should we now remove tests using @requires_legacy_unicode_capi() decorator? Or are these tests kept on purpose?

For example, this test is now always skipped:

$ ./python -m test test_capi -m test.test_capi.test_getargs.String_TestCase.test_Z -v

test_Z (test.test_capi.test_getargs.String_TestCase.test_Z) ... skipped 'requires legacy Unicode C API'

See also issue #92536 and PEP 623: Remove wstr from Unicode.

cc @methane @serhiy-storchaka

Linked PRs

Activity

  1. added a commit that references this issue on Sep 7, 2023
  2. serhiy-storchaka commented on Sep 7, 2023

    @serhiy-storchaka
    Member

    I have examined them all, and they do not contain anything that could be tested. The fact that particular format units are errors is already tested in other tests.

  3. added a commit that references this issue on Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions