Repository navigation
PEP 623: Remove wstr from Unicode #92536
Copy link
Copy link
Closed
Labels
type-featureA feature request or enhancementA feature request or enhancement
Description
Activity
- addedtype-featureA feature request or enhancementA feature request or enhancement
on May 9, 2022 FYI the lxml project still uses uses deprecated functions:
src/lxml/parser.pxi: py_buffer_len = python.PyUnicode_GET_DATA_SIZE(utext) src/lxml/parser.pxi: c_len = python.PyUnicode_GET_DATA_SIZE(text) src/lxml/python.pxd: cdef Py_ssize_t PyUnicode_GET_DATA_SIZE(object ustring)Compiler warnings on Python 3.11:
src/lxml/etree.c: In function ‘__pyx_f_4lxml_5etree_11_BaseParser__parseUnicodeDoc’: src/lxml/etree.c:119132:5: warning: ‘PyUnicode_GET_DATA_SIZE’ is deprecated [-Wdeprecated-declarations] 119132 | __pyx_v_py_buffer_len = PyUnicode_GET_DATA_SIZE(__pyx_v_utext); | ^~~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/python3.11/unicodeobject.h:1042, from /usr/include/python3.11/Python.h:51, from src/lxml/etree.c:99: /usr/include/python3.11/cpython/unicodeobject.h:657:26: note: declared here 657 | static inline Py_ssize_t PyUnicode_GET_DATA_SIZE(PyObject *op) | ^~~~~~~~~~~~~~~~~~~~~~~ src/lxml/etree.c:119141:5: warning: ‘PyUnicode_AS_DATA’ is deprecated [-Wdeprecated-declarations] 119141 | __pyx_v_c_text = PyUnicode_AS_DATA(__pyx_v_utext); | ^~~~~~~~~~~~~~ /usr/include/python3.11/cpython/unicodeobject.h:691:27: note: declared here 691 | static inline const char* PyUnicode_AS_DATA(PyObject *op) | ^~~~~~~~~~~~~~~~~ src/lxml/etree.c: In function ‘__pyx_f_4lxml_5etree__parseDoc’: src/lxml/etree.c:125721:7: warning: ‘PyUnicode_GET_DATA_SIZE’ is deprecated [-Wdeprecated-declarations] 125721 | __pyx_v_c_len = PyUnicode_GET_DATA_SIZE(__pyx_v_text); | ^~~~~~~~~~~~~ /usr/include/python3.11/cpython/unicodeobject.h:657:26: note: declared here 657 | static inline Py_ssize_t PyUnicode_GET_DATA_SIZE(PyObject *op) | ^~~~~~~~~~~~~~~~~~~~~~~Thank you for reporting.
I reported it to lxml. https://bugs.launchpad.net/lxml/+bug/1973155I tried to fix it but I don't have enough skill to write compile-time switch in Cython.
If it is difficult to fix it soon, I will resurrectPyUnicode_AS_DATAandPyUnicode_GET_DATA_SIZEas dummy function that just raise an exception.I tried to fix it but I don't have enough skill to write compile-time switch in Cython.
I wrote https://github.com/gevent/gevent/pull/1872/files which has conditional code depending on the Python version.
- added a commit that references this issue
on May 17, 2022 Well done! That was a long journey ;-)
- added a commit that references this issue
on May 23, 2022 - added 8 commits that reference this issue
on Jun 1, 2023
Metadata
Metadata
Assignees
Labels
type-featureA feature request or enhancementA feature request or enhancement
Feature or enhancement
PEP 623
Linked PRs