Skip to content

Add permissions check in CI; expand scope of permissions fix #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catilac merged 2 commits into from
Sep 17, 2026
+52 −2
Merged

Add permissions check in CI; expand scope of permissions fix #1571

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0041f1f
Add permissions check in CI; expand scope of permissions fix in snapc…
catilac Sep 17, 2026
b729882
make permissions changes at end
catilac Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make permissions changes at end
  • Loading branch information
@catilac
catilac committed Sep 17, 2026
commit b729882c9a9aef8b2f23bc0c450a028e0306cba6
35 changes: 35 additions & 0 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,37 @@ tasks.register("setExecutablePermissions") {
}
}

tasks.register("fixDebPermissions") {
description = "Rebuilds the .deb so binaries under opt/processing/lib/app/resources keep their executable bit " +
"(jpackage's own deb assembly does not reliably preserve it for arbitrary resource files)"
group = "compose desktop"
onlyIf { OperatingSystem.current().isLinux }

val execOps = objects.newInstance<ExecOps>().execOps

doLast {
val debDir = layout.buildDirectory.dir("compose/binaries/main/deb").get().asFile
val deb = debDir.listFiles { f -> f.name.startsWith("processing") && f.name.endsWith(".deb") }
?.singleOrNull()
?: throw GradleException("Expected exactly one processing*.deb in $debDir")

val extractDir = debDir.resolve("${deb.nameWithoutExtension}-fixperms")
extractDir.deleteRecursively()

execOps.exec {
commandLine(
"fakeroot", "bash", "-c",
"dpkg-deb -R '${deb.absolutePath}' '${extractDir.absolutePath}' && " +
"find '${extractDir.absolutePath}/opt/processing/lib/app/resources' " +
"-path '*/bin/*' -type f -exec chmod +x {} + && " +
"dpkg-deb -b '${extractDir.absolutePath}' '${deb.absolutePath}'"
)
}

extractDir.deleteRecursively()
}
}

afterEvaluate {
tasks.named("prepareAppResources").configure {
dependsOn("includeProcessingResources")
Expand All @@ -681,5 +712,9 @@ afterEvaluate {
// app image before permissions are restored on it.
tasks.named("packageDeb").configure {
dependsOn("setExecutablePermissions")
// jpackage's own --type deb assembly doesn't reliably preserve the
// executable bit on arbitrary resource binaries (java, windres, ...);
// rebuild the .deb afterward via dpkg-deb to force it back on.
finalizedBy("fixDebPermissions")
}
}
Loading