Skip to content

Add permissions check in CI; expand scope of permissions fix #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catilac merged 2 commits into from
Sep 17, 2026
+52 −2
Merged

Add permissions check in CI; expand scope of permissions fix #1571

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0041f1f
Add permissions check in CI; expand scope of permissions fix in snapc…
catilac Sep 17, 2026
b729882
make permissions changes at end
catilac Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add permissions check in CI; expand scope of permissions fix in snapc… 
…raft.yml and flathub.yml
  • Loading branch information
@catilac
catilac committed Sep 17, 2026
commit 0041f1f2301d27d00811b96c401fa5af068e54c6
8 changes: 8 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@ jobs:
- name: Package Processing with Gradle
run: ./gradlew packageDistributionForCurrentOS

- name: Verify binary permissions in .deb
if: matrix.os_prefix == 'linux'
run: |
DEB=$(ls app/build/compose/binaries/main/deb/processing*.deb)
dpkg-deb -x "$DEB" /tmp/debcheck
test -x /tmp/debcheck/opt/processing/lib/app/resources/jdk/bin/java
test -x /tmp/debcheck/opt/processing/lib/app/resources/modes/java/application/launch4j/bin/windres

- name: Add artifact
uses: actions/upload-artifact@v4
if: ${{ github.event_name != 'pull_request' }}
Expand Down
7 changes: 7 additions & 0 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,4 +675,11 @@ afterEvaluate {
dependsOn("includeJdk")
finalizedBy("setExecutablePermissions")
}
// finalizedBy above only guarantees setExecutablePermissions runs after
// createDistributable, not before packageDeb, which merely depends on
// createDistributable transitively - without this, jpackage can read the
// app image before permissions are restored on it.
tasks.named("packageDeb").configure {
dependsOn("setExecutablePermissions")
}
}
2 changes: 1 addition & 1 deletion app/linux/flathub.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ modules:
- ar x processing.deb
- tar --zstd -xf data.tar.zst
- mv opt/processing/* /app/
- find /app/lib/app/resources/jdk/bin -type f -exec chmod +x {} +
- find /app/lib/app/resources -path "*/bin/*" -type f -exec chmod +x {} +

# Install the desktop file and icon
- install -D /app/lib/processing-Processing.desktop /app/share/applications/$identifier.desktop
Expand Down
2 changes: 1 addition & 1 deletion app/linux/snapcraft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ parts:
override-prime: |
snapcraftctl prime
rm -vf usr/lib/jvm/java-17-openjdk-*/lib/security/cacerts
chmod -R +x opt/processing/lib/app/resources/jdk
find opt/processing/lib/app/resources -path "*/bin/*" -type f -exec chmod +x {} +
Loading