Conversation
mkurz
commented
Jun 12, 2026
| .bind(new Lang(Locale.FRENCH), TypedMap.empty(), Map("note" -> "foo").asJava) | ||
| myFormFr.errors("note").get(0).message() must beEqualTo("Größe muss zwischen 10 und 100 sein") | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Test only removed temporary. Needs to be roll backed before merge this PR.
mkurz
force-pushed
the
locale_context_holder_removal_refactoring
branch
from
June 12, 2026 14:08
7fe3738 to
aa94acb
Compare
mkurz
force-pushed
the
locale_context_holder_removal_refactoring
branch
2 times, most recently
from
June 17, 2026 12:27
dc76b46 to
e08aed5
Compare
mkurz
force-pushed
the
locale_context_holder_removal_refactoring
branch
from
September 23, 2026 07:54
e08aed5 to
7175d11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛔ DO NOT MERGE YET. ⛔
This PR currently is just a proof that after
got merged we can totally remove
LocaleContextHolderand instead passLocalewhere needed (because now we control the binding code since we removed the Spring dependencies).