Avoid accessing ThreadLocal by mkurz · Pull Request #13959 · playframework/playframework

mkurz · 2026-05-28T14:37:50Z

Requires HV-2219 Expose constraint validator payload to message interpolators hibernate/hibernate-validator#1989
- Ticket: https://hibernate.atlassian.net/browse/HV-2219
- Means we need to wait for at least next Hibernate Validator release (but not urgent anyway)

Covered by following test:

playframework/web/play-java-forms/src/test/scala/play/data/FormSpec.scala

Lines 1630 to 1652 in 8c364d6

    
           "have the validator translate error messages correctly" in new WithApplication( 
        
             application("play.i18n.langs" -> List("de", "en", "ja")) 
        
           ) { 
        
             override def running() = { 
        
               val myFormJa = formFactory 
        
                 .form(classOf[JavaI18NValidatorForm]) 
        
                 .bind(new Lang(Locale.JAPANESE), TypedMap.empty(), Map("note" -> "foo").asJava) 
        
               myFormJa.errors("note").get(0).message() must beEqualTo("10 から 100 の間のサイズにしてください") 
        
               val myFormEn = formFactory 
        
                 .form(classOf[JavaI18NValidatorForm]) 
        
                 .bind(new Lang(Locale.ENGLISH), TypedMap.empty(), Map("note" -> "foo").asJava) 
        
               myFormEn.errors("note").get(0).message() must beEqualTo("size must be between 10 and 100") 
        
               val myFormDe = formFactory 
        
                 .form(classOf[JavaI18NValidatorForm]) 
        
                 .bind(new Lang(Locale.GERMAN), TypedMap.empty(), Map("note" -> "foo").asJava) 
        
               myFormDe.errors("note").get(0).message() must beEqualTo("Größe muss zwischen 10 und 100 sein") 
        
               // French not defined in config, fall back to default (which is german, since it is first in the list) 
        
               val myFormFr = formFactory 
        
                 .form(classOf[JavaI18NValidatorForm]) 
        
                 .bind(new Lang(Locale.FRENCH), TypedMap.empty(), Map("note" -> "foo").asJava) 
        
               myFormFr.errors("note").get(0).message() must beEqualTo("Größe muss zwischen 10 und 100 sein") 
        
             }

mkurz · 2026-06-19T11:23:33Z

[error] Test javaguide.forms.JavaForms.constraints failed: jakarta.validation.ValidationException: HV000149: An exception occurred during message interpolation, took 0.07 sec
[error]     at org.hibernate.validator.internal.engine.validationcontext.AbstractValidationContext.interpolate(AbstractValidationContext.java:313)
[error]     at org.hibernate.validator.internal.engine.validationcontext.AbstractValidationContext.addConstraintFailure(AbstractValidationContext.java:218)
[error]     at org.hibernate.validator.internal.engine.constraintvalidation.SimpleConstraintTree.validateConstraints(SimpleConstraintTree.java:45)
[error]     at org.hibernate.validator.internal.metadata.core.MetaConstraint.validateConstraint(MetaConstraint.java:124)
[error]     at org.hibernate.validator.internal.engine.ValidatorImpl.validateMetaConstraint(ValidatorImpl.java:601)
[error]     at org.hibernate.validator.internal.engine.ValidatorImpl.validateConstraintsForSingleDefaultGroupElement(ValidatorImpl.java:546)
[error]     at org.hibernate.validator.internal.engine.ValidatorImpl.validateConstraintsForDefaultGroup(ValidatorImpl.java:512)
[error]     at org.hibernate.validator.internal.engine.ValidatorImpl.validateConstraintsForCurrentGroup(ValidatorImpl.java:448)
[error]     at org.hibernate.validator.internal.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:398)
[error]     at org.hibernate.validator.internal.engine.ValidatorImpl.validate(ValidatorImpl.java:170)
[error]     at play.data.Form.lambda$runValidation$0(Form.java:1123)
[error]     at play.data.Form.withRequestLocale(Form.java:1880)
[error]     at play.data.Form.runValidation(Form.java:1108)
[error]     at play.data.Form.bind(Form.java:1268)
[error]     at play.data.Form.bind(Form.java:1241)
[error]     at javaguide.forms.JavaForms.constraints(JavaForms.java:108)
[error]     at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
[error]     at java.lang.reflect.Method.invoke(Method.java:565)
[error]     ...
[error] Caused by: java.lang.NullPointerException: Cannot invoke "play.i18n.Lang.toLocale()" because the return value of "play.data.validation.Constraints$ValidationPayload.getLang()" is null
[error]     at play.data.validation.ValidatorFactoryProvider$1.interpolate(ValidatorFactoryProvider.java:49)
[error]     at org.hibernate.validator.internal.engine.validationcontext.AbstractValidationContext.interpolate(AbstractValidationContext.java:304)
[error]     ... 52 more
```

Covered by test "have the validator translate error messages correctly" in FormSpec.scala

mkurz marked this pull request as draft May 28, 2026 14:37

mkurz force-pushed the avoid_spring_threadlocal branch 5 times, most recently from 69ce098 to 50a8364 Compare June 3, 2026 11:21

mkurz force-pushed the avoid_spring_threadlocal branch from 50a8364 to d538c45 Compare June 8, 2026 08:51

mkurz mentioned this pull request Jun 12, 2026

No longer depend on Spring libraries for Java form binding #13995

Merged

mkurz force-pushed the avoid_spring_threadlocal branch from d538c45 to 20a9734 Compare June 12, 2026 13:21

mkurz mentioned this pull request Jun 12, 2026

Remove LocaleContextHolder; pass Locale everywhere #13996

Draft

2 tasks

mkurz force-pushed the avoid_spring_threadlocal branch from 20a9734 to 687fb66 Compare June 17, 2026 12:26

mkurz mentioned this pull request Jun 19, 2026

HV-2219 Expose constraint validator payload to message interpolators hibernate/hibernate-validator#1989

Merged

mkurz force-pushed the avoid_spring_threadlocal branch from ef815a1 to b20a457 Compare June 20, 2026 20:35

mkurz added 3 commits September 23, 2026 02:02

Avoid accessing ThreadLocal

f695fad

Covered by test "have the validator translate error messages correctly" in FormSpec.scala

REVERT LATER Use hibernate validator snapshot

8077ff0

Use released API for request-local validation locale

e640527

mkurz force-pushed the avoid_spring_threadlocal branch from b20a457 to e640527 Compare September 23, 2026 00:18

Navigation Menu

Uh oh!

Avoid accessing ThreadLocal - #13959

Avoid accessing ThreadLocal#13959
mkurz wants to merge 3 commits into
playframework:mainfrom
mkurz:avoid_spring_threadlocal

mkurz commented May 28, 2026

Uh oh!

mkurz commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	"have the validator translate error messages correctly" in new WithApplication(
	application("play.i18n.langs" -> List("de", "en", "ja"))
	) {
	override def running() = {
	val myFormJa = formFactory
	.form(classOf[JavaI18NValidatorForm])
	.bind(new Lang(Locale.JAPANESE), TypedMap.empty(), Map("note" -> "foo").asJava)
	myFormJa.errors("note").get(0).message() must beEqualTo("10 から 100 の間のサイズにしてください")
	val myFormEn = formFactory
	.form(classOf[JavaI18NValidatorForm])
	.bind(new Lang(Locale.ENGLISH), TypedMap.empty(), Map("note" -> "foo").asJava)
	myFormEn.errors("note").get(0).message() must beEqualTo("size must be between 10 and 100")
	val myFormDe = formFactory
	.form(classOf[JavaI18NValidatorForm])
	.bind(new Lang(Locale.GERMAN), TypedMap.empty(), Map("note" -> "foo").asJava)
	myFormDe.errors("note").get(0).message() must beEqualTo("Größe muss zwischen 10 und 100 sein")

	// French not defined in config, fall back to default (which is german, since it is first in the list)
	val myFormFr = formFactory
	.form(classOf[JavaI18NValidatorForm])
	.bind(new Lang(Locale.FRENCH), TypedMap.empty(), Map("note" -> "foo").asJava)
	myFormFr.errors("note").get(0).message() must beEqualTo("Größe muss zwischen 10 und 100 sein")
	}

Uh oh!

Conversation

mkurz commented May 28, 2026

Uh oh!

mkurz commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant