Skip to content

Fix phpstan/phpstan#6934: Nullsafe operator does not narrow down type #5322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phpstan-bot wants to merge 8 commits into from
Closed

Fix phpstan/phpstan#6934: Nullsafe operator does not narrow down type #5322

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
36c7aaf
Fix phpstan/phpstan#6934: nullsafe operator does not narrow type for …
github-actions[bot] Mar 29, 2026
658bce3
Address review: add rule test and post-chain type assertions for bug-…
phpstan-bot Mar 30, 2026
10db966
Remove unnecessary #[RequiresPhp] from testBug6934
phpstan-bot Mar 30, 2026
9f728c1
Add back #[RequiresPhp('>= 8.0')] to testBug6934
phpstan-bot Mar 30, 2026
e82198a
Deduplicate files
VincentLanglet Mar 30, 2026
03a0d6b
Update bug-6934.php
staabm Mar 30, 2026
53b1634
Add assert
VincentLanglet Mar 30, 2026
9f51d39
Add test
VincentLanglet Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add back #[RequiresPhp('>= 8.0')] to testBug6934 
The test data file uses DOMNode which has version-dependent property
types via #[LanguageLevelTypeAware] in phpstorm-stubs. On PHP < 8.0,
the analysis may produce different errors since DOMNode::$parentNode
lacks a native type declaration. The // lint >= 8.0 comment in the
test data file is only processed by TypeInferenceTestCase, not by
RuleTestCase::analyse(), so #[RequiresPhp] is needed to skip the
test on older PHP versions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@phpstan-bot @claude @staabm
2 people authored and staabm committed Mar 31, 2026
commit 9f728c1d10d4afe0477ad17a68ffac17094ea0c8
1 change: 1 addition & 0 deletions tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3945,6 +3945,7 @@ public function testBug7369(): void
]);
}

#[RequiresPhp('>= 8.0')]

@staabm staabm Mar 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this test fail on php 8.0?

@phpstan-bot phpstan-bot Mar 30, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Removed the #[RequiresPhp('>= 8.0')] attribute from testBug6934() since it's unnecessary — RuleTestCase uses php-parser which can parse nullsafe ?-> syntax on any PHP version. Other nullsafe tests in the same file (e.g. testNullSafe()) already run without this attribute.

@staabm staabm Mar 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats not true. we need #[RequiresPhp('>= 8.0')]. tell me why the test errors on PHP 8.0

@phpstan-bot phpstan-bot Mar 30, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type inference tests also passed. All checks are green — the commit with #[RequiresPhp('>= 8.0')] restored has been pushed.

public function testBug6934(): void
{
$this->checkThisOnly = false;
Expand Down