Skip to content

Fix phpstan/phpstan#6934: Nullsafe operator does not narrow down type #5322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phpstan-bot wants to merge 8 commits into from
Closed

Fix phpstan/phpstan#6934: Nullsafe operator does not narrow down type #5322

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
36c7aaf
Fix phpstan/phpstan#6934: nullsafe operator does not narrow type for …
github-actions[bot] Mar 29, 2026
658bce3
Address review: add rule test and post-chain type assertions for bug-…
phpstan-bot Mar 30, 2026
10db966
Remove unnecessary #[RequiresPhp] from testBug6934
phpstan-bot Mar 30, 2026
9f728c1
Add back #[RequiresPhp('>= 8.0')] to testBug6934
phpstan-bot Mar 30, 2026
e82198a
Deduplicate files
VincentLanglet Mar 30, 2026
03a0d6b
Update bug-6934.php
staabm Mar 30, 2026
53b1634
Add assert
VincentLanglet Mar 30, 2026
9f51d39
Add test
VincentLanglet Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test
  • Loading branch information
@VincentLanglet @staabm
VincentLanglet authored and staabm committed Mar 31, 2026
commit 9f51d3929e576bfe001c8dd5519e6a09e60f8820
3 changes: 3 additions & 0 deletions tests/PHPStan/Analyser/nsrt/bug-6934.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,15 @@

function removeFromParent(?DOMNode $node): void {
$node?->parentNode?->removeChild($node);
Comment thread
staabm marked this conversation as resolved.
Resolved
$node?->removeChild($node);

assertType('DOMNode|null', $node);
assertType('DOMNode|null', $node?->parentNode);
}

function testNarrowing(?DOMNode $node): void {
$node?->parentNode?->removeChild(assertType('DOMNode', $node));
$node?->removeChild(assertType('DOMNode', $node));
}

class Foo {
Expand Down
Loading